All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: LM Sensors <lm-sensors@lm-sensors.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [lm-sensors] [PATCH 2.6.16-mm1 1/3] rtc: m41t00 driver should
Date: Mon, 27 Mar 2006 17:03:58 +0000	[thread overview]
Message-ID: <20060327190358.742eafb3.khali@linux-fr.org> (raw)
In-Reply-To: <20060324011846.GC9560@mag.az.mvista.com>

Hi Mark,

> The m41t00 i2c/rtc driver currently uses a tasklet to schedule interrupt-level
> writes to the rtc.  This patch causes the driver to use a workqueue instead.
> (...)
>  int
>  m41t00_set_rtc_time(ulong nowtime)
>  {
>  	new_time = nowtime;
>  
>  	if (in_interrupt())
> -		tasklet_schedule(&m41t00_tasklet);
> +		schedule_work(&set_rtc_time_task);
>  	else
> -		m41t00_set_tlet((ulong)&new_time);
> +		m41t00_set((void *)&new_time);

This cast is not needed.

>  
>  	return 0;
>  }

Thanks,
-- 
Jean Delvare


WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: LM Sensors <lm-sensors@lm-sensors.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.16-mm1 1/3] rtc: m41t00 driver should use workqueue instead of tasklet
Date: Mon, 27 Mar 2006 19:03:58 +0200	[thread overview]
Message-ID: <20060327190358.742eafb3.khali@linux-fr.org> (raw)
In-Reply-To: <20060324011846.GC9560@mag.az.mvista.com>

Hi Mark,

> The m41t00 i2c/rtc driver currently uses a tasklet to schedule interrupt-level
> writes to the rtc.  This patch causes the driver to use a workqueue instead.
> (...)
>  int
>  m41t00_set_rtc_time(ulong nowtime)
>  {
>  	new_time = nowtime;
>  
>  	if (in_interrupt())
> -		tasklet_schedule(&m41t00_tasklet);
> +		schedule_work(&set_rtc_time_task);
>  	else
> -		m41t00_set_tlet((ulong)&new_time);
> +		m41t00_set((void *)&new_time);

This cast is not needed.

>  
>  	return 0;
>  }

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2006-03-27 17:03 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-17  1:13 [lm-sensors] [PATCH 1/1] i2c: m41txx driver for ST i2c RTC chips Mark A. Greer
2006-02-26 11:47 ` Rudolf Marek
2006-02-27 17:09 ` Mark A. Greer
2006-03-05 20:34 ` Rudolf Marek
2006-03-06 11:45 ` Jean Delvare
2006-03-07 17:01 ` Mark A. Greer
2006-03-18  0:12 ` Mark A. Greer
2006-03-23 20:08 ` Jean Delvare
2006-03-23 20:38 ` Mark A. Greer
2006-03-24  1:18   ` [lm-sensors] [PATCH 2.6.16-mm1 1/3] rtc: m41t00 driver should use Mark A. Greer
2006-03-24  1:18     ` [PATCH 2.6.16-mm1 1/3] rtc: m41t00 driver should use workqueue instead of tasklet Mark A. Greer
2006-03-27 17:03     ` Jean Delvare [this message]
2006-03-27 17:03       ` Jean Delvare
2006-03-28  0:22       ` [lm-sensors] [PATCH 2.6.16-mm1 1/3] rtc: m41t00 driver should Mark A. Greer
2006-03-28  0:22         ` [PATCH 2.6.16-mm1 1/3] rtc: m41t00 driver should use workqueue instead of tasklet Mark A. Greer
2006-03-24  1:21   ` [lm-sensors] [PATCH 2.6.16-mm1 2/3] rtc: m41t00 driver cleanup Mark A. Greer
2006-03-24  1:21     ` Mark A. Greer
2006-03-27 17:11     ` [lm-sensors] " Jean Delvare
2006-03-27 17:11       ` Jean Delvare
2006-03-27 22:35       ` [lm-sensors] " Mark A. Greer
2006-03-27 22:35         ` Mark A. Greer
2006-03-28  0:23       ` [lm-sensors] " Mark A. Greer
2006-03-28  0:23         ` Mark A. Greer
2006-03-24  1:24   ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & Mark A. Greer
2006-03-24  1:24     ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Mark A. Greer
2006-03-26 22:58     ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Andrew Morton
2006-03-26 22:58       ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Andrew Morton
2006-03-27 22:34       ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Mark A. Greer
2006-03-27 22:34         ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Mark A. Greer
2006-03-28  0:26       ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Mark A. Greer
2006-03-28  0:26         ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Mark A. Greer
2006-03-28  0:51         ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Andrew Morton
2006-03-28  0:51           ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Andrew Morton
2006-03-28 12:21           ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Jean Delvare
2006-03-28 12:21             ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Jean Delvare
2006-03-28 17:15             ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Mark A. Greer
2006-03-28 17:15               ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Mark A. Greer
2006-03-28 15:54         ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Jean Delvare
2006-03-28 15:54           ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Jean Delvare
2006-03-28 18:11           ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Mark A. Greer
2006-03-28 18:11             ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Mark A. Greer
2006-03-28 18:30             ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Jean Delvare
2006-03-28 18:30               ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Jean Delvare
2006-03-28 23:12               ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Mark A. Greer
2006-03-28 23:12                 ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Mark A. Greer
2006-04-01 17:20                 ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Jean Delvare
2006-04-01 17:20                   ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Jean Delvare
2006-04-03 18:01                   ` [lm-sensors] [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 Mark A. Greer
2006-04-03 18:01                     ` [PATCH 2.6.16-mm1 3/3] rtc: add support for m41t81 & m41t85 chips to m41t00 driver Mark A. Greer
2006-03-23 20:52 ` [lm-sensors] [PATCH 1/1] i2c: m41txx driver for ST i2c RTC chips Jean Delvare
2006-03-24  1:14 ` Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060327190358.742eafb3.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mgreer@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.