From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: CONFIG_ACPI_HOTPLUG_MEMORY=m with x86_64 devel tree II Date: 30 Mar 2006 16:18:11 +0200 Message-ID: <20060330141811.GA84501@muc.de> References: <20060322030208.30e3581e.akpm@osdl.org> <20060322203220.6433e697.kamezawa.hiroyu@jp.fujitsu.com> <20060322192134.GA44212@muc.de> <20060323082732.9828ca2f.kamezawa.hiroyu@jp.fujitsu.com> <20060323000759.GB71469@muc.de> <20060323093609.8eb03249.kamezawa.hiroyu@jp.fujitsu.com> <20060323024306.GA90581@muc.de> <20060323125942.2facb79b.kamezawa.hiroyu@jp.fujitsu.com> <20060330134133.GB80060@muc.de> <20060330225459.c2c53dbe.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from colin.muc.de ([193.149.48.1]:41480 "EHLO mail.muc.de") by vger.kernel.org with ESMTP id S932222AbWC3OSR (ORCPT ); Thu, 30 Mar 2006 09:18:17 -0500 Date: Thu, 30 Mar 2006 16:18:11 +0200 Content-Disposition: inline In-Reply-To: <20060330225459.c2c53dbe.kamezawa.hiroyu@jp.fujitsu.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: KAMEZAWA Hiroyuki Cc: akpm@osdl.org, y-goto@jp.fujitsu.com, linux-acpi@vger.kernel.org, tony.luck@intel.com On Thu, Mar 30, 2006 at 10:54:59PM +0900, KAMEZAWA Hiroyuki wrote: > On 30 Mar 2006 15:41:33 +0200 > Andi Kleen wrote: > > > > > Hi, > > > > I started to implement your suggestion now. > > > > But one problem I noticed and I don't see how the current sparsemem code > > handles correctly is that it makes no attempt to handle hotadd > > areas that cross zone boundaries. Is there code somewhere that rejects > > them? > > > > add_memory() selects a zone which pages are added, before adding memory regardless > of its address. Now this is hard-coded. > > ia64 adds memory to NORMAL. > i386 adds memory to HIGHMEM. > x86_64 adds memory to NORMAL. Yes but what stops ACPI from trying to add memory that crosses a zone? (e.g. from 2GB to 6GB) > > if x86_64 people wants to add memory to DMA32 or some other zone, please add code. I added a check for it in the reserve hotadd code now. -Andi