From: Grant Grundler <grundler@parisc-linux.org>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Grant Grundler <grundler@parisc-linux.org>,
linux-serial@vger.kernel.org, willy@hp.com
Subject: Re: ioremap_nocache() in setup_port() ok?
Date: Thu, 30 Mar 2006 11:12:26 -0700 [thread overview]
Message-ID: <20060330181226.GD9454@colo.lackof.org> (raw)
In-Reply-To: <20060330075752.GA19700@flint.arm.linux.org.uk>
On Thu, Mar 30, 2006 at 08:57:52AM +0100, Russell King wrote:
> On Thu, Mar 30, 2006 at 12:54:10AM -0700, Grant Grundler wrote:
> > Am I correct that serial also wants _nocache() for MMIO space?
>
> Don't know - I've always taken ioremap_nocache() as a mis-understanding
> of what ioremap() itself is supposed to do. Indeed, if you look at
> IO-mapping.txt, ioremap_nocache() is not mentioned, and it's pretty
> clear that ioremap() is what is intended to be used to map MMIO.
I think IO-mapping.txt is stale and whoever added ioremap_nocache
failed to update it.
It would be reasonable to ignore my patch (unless you wanted
to document the expected behavior of serial) if what willy
proposed an hour ago is accepted:
http://lkml.org/lkml/2006/3/30/251
I'll update the IO-mapping.txt based on the outcome of
willy's patch.
thanks,
grant
prev parent reply other threads:[~2006-03-30 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-30 7:54 ioremap_nocache() in setup_port() ok? Grant Grundler
2006-03-30 7:57 ` Russell King
2006-03-30 18:12 ` Grant Grundler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060330181226.GD9454@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=willy@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.