From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Len Brown <len.brown@intel.com>
Cc: linux-acpi@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Thomas Renniger <trenn@suse.de>
Subject: acpi_os_wait_semaphore(): don't complain about timeout
Date: Fri, 31 Mar 2006 15:33:25 -0700 [thread overview]
Message-ID: <200603311533.26023.bjorn.helgaas@hp.com> (raw)
The ASL Acquire operator (17.5.1 in ACPI 3.0 spec) is allowed to
time out and return True without acquiring the semaphore. There's
no indication in the spec that this is an actual error, so this
message should be debug-only, as the message for successful acquisition
is.
This used to be an ACPI_DEBUG_PRINT, but it was mis-classified as
ACPI_DB_ERROR rather than ACPI_DB_MUTEX, so it got swept up in
Thomas' recent patch to enable ACPI error messages even without
CONFIG_ACPI_DEBUG.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work-mm5/drivers/acpi/osl.c
===================================================================
--- work-mm5.orig/drivers/acpi/osl.c 2006-03-23 10:22:40.000000000 -0700
+++ work-mm5/drivers/acpi/osl.c 2006-03-31 14:40:44.000000000 -0700
@@ -816,7 +816,7 @@
}
if (ACPI_FAILURE(status)) {
- ACPI_EXCEPTION((AE_INFO, status,
+ ACPI_DEBUG_PRINT((ACPI_DB_MUTEX,
"Failed to acquire semaphore[%p|%d|%d], %s",
handle, units, timeout,
acpi_format_exception(status)));
next reply other threads:[~2006-03-31 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 22:33 Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-03-31 22:37 acpi_os_wait_semaphore(): don't complain about timeout Moore, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603311533.26023.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.