From: Ralf Baechle <ralf@linux-mips.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unify PFN_* macros
Date: Mon, 3 Apr 2006 13:49:16 +0100 [thread overview]
Message-ID: <20060403124916.GA14044@linux-mips.org> (raw)
In-Reply-To: <20060323162459.6D45D1CE@localhost.localdomain>
On Thu, Mar 23, 2006 at 08:24:59AM -0800, Dave Hansen wrote:
> Just about every architecture defines some macros to do operations on
> pfns. They're all virtually identical. This patch consolidates all
> of them.
>
> One minor glitch is that at least i386 uses them in a very skeletal
> header file. To keep away from #include dependency hell, I stuck
> the new definitions in a new, isolated header.
>
> Of all of the implementations, sh64 is the only one that varied by a
> bit. It used some masks to ensure that any sign-extension got
> ripped away before the arithmetic is done. This has been posted to
> that sh64 maintainers and the development list.
>
> Compiles on x86, x86_64, ia64 and ppc64.
Ehhh... Looks at this patch I wonder if you actually read the MIPS bits
before submitting it:
o replaces PFN_ALIGN with PAGE_ALIGN
o replaces the IP27 definition of PFN_ALIGN with a different one.
How about posting such stuff to linux-arch? No sane person follows l-k.
Ralf
next prev parent reply other threads:[~2006-04-03 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 16:24 [PATCH] unify PFN_* macros Dave Hansen
2006-04-03 12:49 ` Ralf Baechle [this message]
2006-04-03 15:39 ` lkml traffic (was:: [PATCH] unify PFN_* macros) Randy.Dunlap
2006-04-03 17:11 ` Ralf Baechle
2006-04-03 17:45 ` Vadim Lobanov
2006-04-03 21:12 ` Andrew Morton
2006-04-03 23:11 ` Ralf Baechle
2006-04-03 17:48 ` Dave Hansen
2006-04-03 15:56 ` [PATCH] unify PFN_* macros Dave Hansen
[not found] ` <mailman.1144068720.22604.linux-kernel2news@redhat.com>
2006-04-04 5:00 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060403124916.GA14044@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.