From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Martin Samuelsson <sam@home.se>
Cc: linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Johannes Stezenbach <js@linuxtv.org>,
v4l-dvb-maintainer@linuxtv.org
Subject: [-mm patch] drivers/media/video/bt866.c: small fixes
Date: Tue, 4 Apr 2006 18:30:01 +0200 [thread overview]
Message-ID: <20060404163001.GO6529@stusta.de> (raw)
In-Reply-To: <20060404014504.564bf45a.akpm@osdl.org>
On Tue, Apr 04, 2006 at 01:45:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.16-mm2:
>...
> +avermedia-6-eyes-avs6eyes-support.patch
>...
> New v4l driver, and a fix.
>...
This patch contains the following fixes:
- no need to hide MODULE_LICENSE() behind an #ifdef
- use module_{init,exit}; this also fixes the bug that bt866_init()
was never called
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/media/video/bt866.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
--- linux-2.6.17-rc1-mm1-full/drivers/media/video/bt866.c.old 2006-04-04 17:31:55.000000000 +0200
+++ linux-2.6.17-rc1-mm1-full/drivers/media/video/bt866.c 2006-04-04 17:33:38.000000000 +0200
@@ -51,9 +51,7 @@
#include <linux/video_encoder.h>
-#ifdef MODULE_LICENSE
MODULE_LICENSE("GPL");
-#endif
#define DEBUG(x) /* Debug driver */
@@ -372,22 +370,19 @@
/****************************************************************************
* linux kernel module api
****************************************************************************/
-#ifdef MODULE
-int init_module(void)
-#else
-int bt866_init(void)
-#endif
+static int __devinit bt866_init(void)
{
i2c_add_driver(&i2c_driver_bt866);
return 0;
}
-#ifdef MODULE
-void cleanup_module(void)
+static void __devexit bt866_exit(void)
{
i2c_del_driver(&i2c_driver_bt866);
}
-#endif
+
+module_init(bt866_init);
+module_exit(bt866_exit);
/*
* Overrides for Emacs so that we follow Linus's tabbing style.
next prev parent reply other threads:[~2006-04-04 16:30 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-04 8:45 2.6.17-rc1-mm1 Andrew Morton
2006-04-04 14:31 ` 2.6.17-rc1-mm1 Kumar Gala
2006-04-04 16:02 ` 2.6.17-mm1: drivers/w1/: patch undoes reasonable cleanups Adrian Bunk
2006-04-04 16:35 ` Evgeniy Polyakov
2006-04-04 16:29 ` 2.6.17-rc1-mm1: KEXEC became SMP-only Adrian Bunk
2006-04-04 17:22 ` Zachary Amsden
2006-04-04 17:50 ` Eric W. Biederman
2006-04-06 22:37 ` Adrian Bunk
2006-04-04 17:43 ` Eric W. Biederman
2006-04-04 17:51 ` Zachary Amsden
2006-04-04 18:43 ` Eric W. Biederman
2006-04-04 19:23 ` Zachary Amsden
2006-04-04 19:38 ` Muli Ben-Yehuda
2006-04-04 20:25 ` Andrew Morton
2006-04-04 22:02 ` Zachary Amsden
2006-04-04 22:19 ` Andrew Morton
2006-04-04 22:34 ` Zachary Amsden
2006-04-04 22:38 ` Andrew Morton
2006-04-05 0:21 ` Martin Bligh
2006-04-05 2:45 ` Eric W. Biederman
2006-04-04 16:29 ` [-mm patch] i386: pre_intr_init_hook optimization Adrian Bunk
2006-04-04 17:16 ` Zachary Amsden
2006-04-04 16:29 ` 2.6.17-rc1-mm1: why did acpi_ns_build_external_path() become global? Adrian Bunk
2006-04-04 16:30 ` Adrian Bunk [this message]
2006-04-04 18:32 ` [-mm patch] drivers/media/video/bt866.c: small fixes Martin Samuelsson
2006-04-05 7:42 ` Andrew Morton
2006-04-05 9:02 ` Adrian Bunk
2006-04-05 13:44 ` Martin Samuelsson
2006-04-05 8:32 ` Johannes Stezenbach
2006-04-05 13:54 ` Martin Samuelsson
2006-04-04 16:30 ` [-mm patch] fs/nfsd/nfs4state.c: make a struct static Adrian Bunk
2006-04-04 16:30 ` Adrian Bunk
2006-04-04 16:50 ` [NFS] " J. Bruce Fields
2006-04-04 17:29 ` Adrian Bunk
2006-04-04 20:53 ` 2.6.17-rc1-mm1: mlockall() regression on x86_64 Rafael J. Wysocki
2006-04-04 22:24 ` Andrew Morton
2006-04-04 21:53 ` 2.6.17-rc1-mm1 Zan Lynx
2006-04-04 22:09 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-05 7:01 ` 2.6.17-rc1-mm1 Roger Luethi
2006-04-05 7:29 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-05 22:01 ` 2.6.17-rc1-mm1 Roger Luethi
2006-04-04 23:38 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-04 23:38 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 2:05 ` 2.6.17-rc1-mm1 Zou Nan hai
2006-04-05 2:05 ` 2.6.17-rc1-mm1 Zou Nan hai
2006-04-05 16:15 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-05 16:15 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-05 21:17 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 21:17 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 21:37 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-05 21:37 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-05 21:39 ` 2.6.17-rc1-mm1 Andreas Schwab
2006-04-05 21:39 ` 2.6.17-rc1-mm1 Andreas Schwab
2006-04-05 22:01 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-05 22:01 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-06 1:49 ` 2.6.17-rc1-mm1 Antonino A. Daplas
2006-04-06 1:49 ` 2.6.17-rc1-mm1 Antonino A. Daplas
2006-04-06 10:21 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 10:21 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 10:34 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 10:34 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 14:55 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-06 14:55 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-06 10:16 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 10:16 ` 2.6.17-rc1-mm1 Russell King
2006-04-05 22:50 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 22:50 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 2:27 ` 2.6.17-rc1-mm1, nfsd/reiser4 BUG Zan Lynx
2006-04-07 12:27 ` 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error Adrian Bunk
2006-04-07 20:59 ` Andrew Morton
2006-04-09 15:44 ` Adrian Bunk
2006-04-09 15:57 ` Randy.Dunlap
2006-04-07 20:58 ` 2.6.17-rc1-mm1 - detects buggy TSC on GEODE Jim Cromie
2006-04-08 0:07 ` Andrew Morton
2006-04-08 0:25 ` john stultz
2006-04-08 1:15 ` Jim Cromie
2006-04-13 7:39 ` 2.6.17-rc1-mm1 Heiko Carstens
2006-04-13 8:13 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-14 16:07 ` 2.6.17-rc1-mm1 Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060404163001.GO6529@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=js@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=sam@home.se \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.