All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Martin Langer <martin-langer@gmx.de>,
	Stefano Brivio <st3@riseup.net>,
	Michael Buesch <mbuesch@freenet.de>,
	Danny van Dyk <kugelfang@gentoo.org>,
	Andreas Jaggi <andreas.jaggi@waterwave.ch>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linville@tuxdriver.com
Subject: bcm43xx_power.c: uninitialized variable used
Date: Tue, 4 Apr 2006 20:44:18 +0200	[thread overview]
Message-ID: <20060404184418.GU6529@stusta.de> (raw)

The Coverity checker found this case where the variable "tmp" is used 
uninitialized:

<--  snip  -->

...
static int bcm43xx_pctl_clockfreqlimit(struct bcm43xx_private *bcm,
                                       int get_max)
{
        int limit = 0;
        int divisor;
        int selection;
        int err;
        u32 tmp;
        struct bcm43xx_coreinfo *old_core;

        if (!(bcm->chipcommon_capabilities & BCM43xx_CAPABILITIES_PCTL))
                goto out;
        old_core = bcm->current_core;
        err = bcm43xx_switch_core(bcm, &bcm->core_chipcommon);
        if (err)
                goto out;

        if (bcm->current_core->rev < 6) {
...
        } else if (bcm->current_core->rev < 10) {
                selection = (tmp & 0x07);
...

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


                 reply	other threads:[~2006-04-04 18:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060404184418.GU6529@stusta.de \
    --to=bunk@stusta.de \
    --cc=andreas.jaggi@waterwave.ch \
    --cc=jgarzik@pobox.com \
    --cc=kugelfang@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=martin-langer@gmx.de \
    --cc=mbuesch@freenet.de \
    --cc=netdev@vger.kernel.org \
    --cc=st3@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.