From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Greg KH <gregkh@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, Andrew Morton <akpm@osdl.org>
Subject: Re: patch bus_add_device-losing-an-error-return-from-the-probe-method.patch added to gregkh-2.6 tree
Date: Tue, 4 Apr 2006 21:48:56 -0400 [thread overview]
Message-ID: <200604042148.57286.dtor_core@ameritech.net> (raw)
In-Reply-To: <4432EF58.1060502@keyaccess.nl>
On Tuesday 04 April 2006 18:12, Rene Herman wrote:
> To Dmitry, I see you saying "probe() failing is driver's problem. The
> device is still there and should still be presented in sysfs.". No, at
> least in the case of these platform drivers (or at least these old ISA
> cards using the platform driver interface), a -ENODEV return from the
> probe() method would mean the device is _not_ present (or not found at
> least). NODEV.
Or you could separate device probing code from driver->probe(). BTW I think
that ->probe() is not the best name for that method. It really is supposed
to allocate resources and initialize the device so that it is ready to be
used, not to verify that device is present. The code that created device
shoudl've done that.
--
Dmitry
next prev parent reply other threads:[~2006-04-05 1:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 5:32 bus_add_device() losing an error return from the probe() method Rene Herman
2006-03-26 1:53 ` Andrew Morton
2006-03-26 22:30 ` Rene Herman
2006-03-26 22:30 ` Rene Herman
2006-03-26 1:53 ` Andrew Morton
2006-04-04 19:10 ` patch bus_add_device-losing-an-error-return-from-the-probe-method.patch added to gregkh-2.6 tree gregkh
2006-04-04 19:10 ` gregkh
2006-04-04 20:23 ` Dmitry Torokhov
2006-04-04 21:00 ` Greg KH
2006-04-04 21:00 ` Greg KH
2006-04-04 21:15 ` Greg KH
2006-04-04 21:15 ` Greg KH
2006-04-04 21:22 ` Andrew Morton
2006-04-04 21:22 ` Andrew Morton
2006-04-04 21:28 ` Dmitry Torokhov
2006-04-04 21:45 ` Greg KH
2006-04-05 1:35 ` Dmitry Torokhov
2006-04-05 1:35 ` Dmitry Torokhov
2006-04-05 7:36 ` Russell King
2006-04-05 7:36 ` Russell King
2006-04-06 1:05 ` Greg KH
2006-04-06 1:05 ` Greg KH
2006-04-05 1:59 ` Dmitry Torokhov
2006-04-05 1:59 ` Dmitry Torokhov
2006-04-04 21:45 ` Greg KH
2006-04-04 21:28 ` Dmitry Torokhov
2006-04-04 22:12 ` Rene Herman
2006-04-05 0:23 ` Rene Herman
2006-04-05 0:23 ` Rene Herman
2006-04-05 1:45 ` Dmitry Torokhov
2006-04-05 1:45 ` Dmitry Torokhov
2006-04-05 18:36 ` Rene Herman
2006-04-05 18:36 ` Rene Herman
2006-04-05 18:44 ` Dmitry Torokhov
2006-04-05 18:44 ` Dmitry Torokhov
2006-04-05 1:48 ` Dmitry Torokhov
2006-04-05 1:48 ` Dmitry Torokhov [this message]
2006-04-05 13:50 ` Rene Herman
2006-04-05 14:59 ` Dmitry Torokhov
2006-04-05 21:22 ` Rene Herman
2006-04-05 21:22 ` Rene Herman
2006-04-05 14:59 ` Dmitry Torokhov
2006-04-05 13:50 ` Rene Herman
2006-04-05 13:55 ` Rene Herman
2006-04-05 13:55 ` Rene Herman
2006-04-04 22:12 ` Rene Herman
2006-04-04 20:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604042148.57286.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@keyaccess.nl \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.