All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus@valinux.co.jp>
To: xen-devel@lists.xensource.com
Cc: christian.limpach@gmail.com, Magnus Damm <magnus@valinux.co.jp>
Subject: [PATCH] Fix __XEN_INTERFACE_VERSION__ old config breakage
Date: Wed,  5 Apr 2006 07:45:34 +0900 (JST)	[thread overview]
Message-ID: <20060404224615.7472.23940.sendpatchset@cherry.local> (raw)

Fix __XEN_INTERFACE_VERSION__ old config breakage

For old kernel configurations that lack CONFIG_XEN_INTERFACE_VERSION,
__XEN_INTERFACE_VERSION__ will currently be defined but set to nothing. 

If a xen-enabled kernel is built separately from the xen-unstable dist,
the following error occurs with xen-unstable-9415:

#
# using defaults found in .config
#
  SPLIT   include/linux/autoconf.h -> include/config/*
  CC      arch/i386/kernel/asm-offsets.s
In file included from include/xen/interface/xen.h:439,
                 from include/asm/mach-xen/asm/page.h:20,
                 from include/asm/thread_info.h:14,
                 from include/linux/thread_info.h:21,
                 from include/linux/preempt.h:10,
                 from include/linux/spinlock.h:50,
                 from include/linux/capability.h:45,
                 from include/linux/sched.h:7,
                 from arch/i386/kernel/asm-offsets.c:7:
include/xen/interface/xen-compat.h:22:31: #if with no expression
include/xen/interface/xen-compat.h:26:31: #if with no expression
make[1]: *** [arch/i386/kernel/asm-offsets.s] Error 1
make: *** [prepare0] Error 2
$

The patch below fixes the problem and makes the logic in xen-compat.h work
correctly - __XEN_INTERFACE_VERSION__ now becomes unset if the config option
is missing.

Signed-Off-By: Magnus Damm <magnus@valinux.co.jp>

--- linux-2.6-xen-sparse/arch/i386/Makefile
+++ linux-2.6-xen-sparse/arch/i386/Makefile	2006-03-31 16:36:09.000000000 +0900
@@ -45,8 +45,10 @@ CFLAGS				+= $(shell if [ $(call cc-vers
 
 CFLAGS += $(cflags-y)
 
+ifneq   "$(CONFIG_XEN_INTERFACE_VERSION)" ""
 cppflags-$(CONFIG_XEN) += \
 	-D__XEN_INTERFACE_VERSION__=$(CONFIG_XEN_INTERFACE_VERSION)
+endif
 
 CPPFLAGS += $(cppflags-y)

             reply	other threads:[~2006-04-04 22:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-04 22:45 Magnus Damm [this message]
2006-04-06 14:11 ` [PATCH] Fix __XEN_INTERFACE_VERSION__ old config breakage Keir Fraser
2006-04-07  0:33 ` Christian Limpach
2006-04-07  4:17   ` Magnus Damm
2006-04-07  7:33     ` Keir Fraser
2006-04-07  7:48       ` Magnus Damm
2006-04-07  8:54         ` Keir Fraser
2006-04-07  9:10           ` Magnus Damm
2006-04-07  9:34             ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060404224615.7472.23940.sendpatchset@cherry.local \
    --to=magnus@valinux.co.jp \
    --cc=christian.limpach@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.