From: Andrew Morton <akpm@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] parse_date(): fix parsing 03/10/2006
Date: Tue, 4 Apr 2006 23:40:48 -0700 [thread overview]
Message-ID: <20060404234048.0236886e.akpm@osdl.org> (raw)
In-Reply-To: <7virpo4jxf.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
>
> Andrew Morton <akpm@osdl.org> writes:
>
> > But there was a second problem. Once the parsing had misbehaved, Len
> > managed to create a commit which was six months in the future:
> >
> > commit 8313524a0d466f451a62709aaedf988d8257b21c
> > Author: Bob Moore <robert.moore@intel.com>
> > Date: Tue Oct 3 00:00:00 2006 -0400
> >
> > ACPI: ACPICA 20060310
> >
> > Will your fix prevent that from happening? If not, perhaps some basic
> > sanity checking might be appropriate.
>
> You _might_ get an e-mail to fix kernel problems from yourself
> in the future, in which case you would want to commit with
> future author date, like this ;-).
>
> People would often deal with dates in the past (way in the past
> when talking about importing foreign SCM history), but probably
> it would never make sense to do dates way into the future. I'll
> think about it.
>
Well it doesn't have to be fatal, of course. Some "do you really want to
do this [y/n]?" prompt, with a command option to override it. Or simply
print a big warning.
Whatever.
next prev parent reply other threads:[~2006-04-05 6:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 6:00 [PATCH] parse_date(): fix parsing 03/10/2006 Junio C Hamano
2006-04-05 6:16 ` Andrew Morton
2006-04-05 6:26 ` Junio C Hamano
2006-04-05 6:40 ` Andrew Morton [this message]
2006-04-05 22:39 ` [RFC/PATCH] date parsing: be friendlier to our European friends Junio C Hamano
2006-04-05 22:47 ` Sam Ravnborg
2006-04-05 22:54 ` Junio C Hamano
2006-07-14 10:26 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060404234048.0236886e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.