From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1FRLFt-0002ig-JI for user-mode-linux-devel@lists.sourceforge.net; Wed, 05 Apr 2006 20:33:57 -0700 Received: from smtp.osdl.org ([65.172.181.4]) by mail.sourceforge.net with esmtps (TLSv1:DES-CBC3-SHA:168) (Exim 4.44) id 1FRLFr-0001QN-N8 for user-mode-linux-devel@lists.sourceforge.net; Wed, 05 Apr 2006 20:33:57 -0700 From: Andrew Morton Subject: Re: [uml-devel] Re: [PATCH 12/16] UML - Memory hotplug Message-Id: <20060405203233.5fb222ae.akpm@osdl.org> In-Reply-To: <20060406015636.GE6924@ccure.user-mode-linux.org> References: <200603241814.k2OIExNn005555@ccure.user-mode-linux.org> <20060324144535.37b3daf7.akpm@osdl.org> <20060325010524.GA8117@ccure.user-mode-linux.org> <44343E86.30301@google.com> <20060406015636.GE6924@ccure.user-mode-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Wed, 5 Apr 2006 20:32:33 -0700 To: Jeff Dike Cc: phillips@google.com, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Jeff Dike wrote: > > + /* 0 means don't wait (like GFP_ATOMIC) and > + * don't dip into emergency pools (unlike > + * GFP_ATOMIC). > + */ > + new = kmalloc(sizeof(*new), 0); What we've done in the past here is to use (GFP_ATOMIC & ~__GFP_HIGH). It amounts to the same thing, but it carries some semantic meaning: "whatever GFP_ATOMIC measn, only don't dip into page reserves". Plus it future-safes us against changes in GFP_ATOMIC. I'll make that change. ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751350AbWDFDeB (ORCPT ); Wed, 5 Apr 2006 23:34:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751354AbWDFDeB (ORCPT ); Wed, 5 Apr 2006 23:34:01 -0400 Received: from smtp.osdl.org ([65.172.181.4]:47753 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751350AbWDFDeA (ORCPT ); Wed, 5 Apr 2006 23:34:00 -0400 Date: Wed, 5 Apr 2006 20:32:33 -0700 From: Andrew Morton To: Jeff Dike Cc: phillips@google.com, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [uml-devel] Re: [PATCH 12/16] UML - Memory hotplug Message-Id: <20060405203233.5fb222ae.akpm@osdl.org> In-Reply-To: <20060406015636.GE6924@ccure.user-mode-linux.org> References: <200603241814.k2OIExNn005555@ccure.user-mode-linux.org> <20060324144535.37b3daf7.akpm@osdl.org> <20060325010524.GA8117@ccure.user-mode-linux.org> <44343E86.30301@google.com> <20060406015636.GE6924@ccure.user-mode-linux.org> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeff Dike wrote: > > + /* 0 means don't wait (like GFP_ATOMIC) and > + * don't dip into emergency pools (unlike > + * GFP_ATOMIC). > + */ > + new = kmalloc(sizeof(*new), 0); What we've done in the past here is to use (GFP_ATOMIC & ~__GFP_HIGH). It amounts to the same thing, but it carries some semantic meaning: "whatever GFP_ATOMIC measn, only don't dip into page reserves". Plus it future-safes us against changes in GFP_ATOMIC. I'll make that change.