From: Andreas Gruenbacher <agruen@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] modules_install must not remove existing modules
Date: Wed, 5 Apr 2006 23:33:50 +0200 [thread overview]
Message-ID: <200604052333.51085.agruen@suse.de> (raw)
When installing external modules with `make modules_install', the
first thing that happens is a rm -rf of the target directory. This
works only once, and breaks when installing more than one (set of)
external module(s). Bug introduced in:
http://www.kernel.org/hg/linux-2.6/?cs=bbb3915836f5
Sam, is this fix okay with you?
Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Index: linux-2.6.16/Makefile
===================================================================
--- linux-2.6.16.orig/Makefile
+++ linux-2.6.16/Makefile
@@ -1131,7 +1131,6 @@ modules_install: _emodinst_ _emodinst_po
install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extra)
.PHONY: _emodinst_
_emodinst_:
- $(Q)rm -rf $(MODLIB)/$(install-dir)
$(Q)mkdir -p $(MODLIB)/$(install-dir)
$(Q)$(MAKE) -rR -f $(srctree)/scripts/Makefile.modinst
--
Andreas Gruenbacher <agruen@suse.de>
Novell / SUSE Labs
next reply other threads:[~2006-04-05 21:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 21:33 Andreas Gruenbacher [this message]
2006-04-05 21:52 ` [PATCH] modules_install must not remove existing modules Valdis.Kletnieks
2006-04-05 22:06 ` Andreas Gruenbacher
2006-04-05 22:33 ` Gene Heskett
2006-04-05 22:12 ` Sam Ravnborg
2006-04-05 22:21 ` Andreas Gruenbacher
2006-04-06 4:04 ` Valdis.Kletnieks
2006-04-06 6:43 ` Sam Ravnborg
2006-04-06 20:28 ` Randy.Dunlap
2006-04-06 20:29 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604052333.51085.agruen@suse.de \
--to=agruen@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.