Re: udev 085 warnings

[Michael Buesch <mb@bu3sch.de>]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

On Wednesday 05 April 2006 21:03, Kay Sievers wrote:
> On Wed, Apr 05, 2006 at 11:10:40AM +0200, Jan Engelhardt wrote:
> > I am currently compiling udev-085-14.src.rpm from the opensuse
> > OSS-factory tree on a 64-bit arch and get a lot of these warnings:
> >
> > fat.c:325: warning: cast increases required alignment of target type
> > 325:
> >                 next = le32_to_cpu(*((uint32_t *) buf) & 0x0fffffff);

Hm, I don't know what this code is about, but is it actually correct?
I mean, it masks the value of buf, which is appearently a little-endian
32bit value with 0x0fffffff (which is CPU order). Is that intentional?
Or should it be something like that instead:
	next = le32_to_cpu(*((uint32_t *) buf)) & 0x0fffffff;

> > Will there be a proper fix or is this just another of these nice gcc
> > warnings that are superfluous?
>
> GCC is correct warning about that, cause the Makefile asked for that
> kind of warning. The buffer access is always aligned but the compiler
> can't know that. To get rid of it, you would need to memcpy() the integer
> in a variable or access it byte by byte and shift it to an integer
> value. Removing -Wcast-align should be the easiest. :)

-- 
Greetings Michael.

[-- Attachment #2: Type: application/pgp-signature, Size: 191 bytes --]