Re: Bug in vga16fb?

[Ondrej Zajicek <santiago@mail.cz>]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

On Thu, Apr 06, 2006 at 09:56:42PM +0800, Antonino A. Daplas wrote:
> Ondrej Zajicek wrote:
> > On Thu, Apr 06, 2006 at 12:48:48AM +0200, Petr Vandrovec wrote:
> >> Ondrej Zajicek wrote:
> > 
> > Even if we find some possibility to autodetect what hardware does (or in
> > case of another, non-VGA hardware using CFB4 mode) there would be
> > problem that driver cannot say it to userspace (or generic kernel
> > functions like cfb_imageblit). Maybe there should be some flag in
> > type_aux specifying whether given packed pixel mode is LSB-first or
> > MSB-first (relevant only for bpp % 8 != 0) ?
> > 
> 
> var->{red|green|blue|transp}.msb_right

I think that this bit says something different - ordering of bits inside
one color component. This is OK for all VGA (MSB bit of color index is
left), i hope.

Problem is in ordering of pixels inside a byte, which is completely
orthogonal to bitplane.msb_right-ness.

But maybe i misunderstood of meaning of 
var->{red|green|blue|transp}.msb_right ...


-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago@mail.cz, jabber: santiago@njs.netlab.cz)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]