From: "Jordan Crouse" <jordan.crouse@amd.com>
To: "Rodolfo Giometti" <giometti@linux.it>
Cc: "Linux MIPS" <linux-mips@linux-mips.org>
Subject: Re: sysfs interface for Au1xxx power management
Date: Thu, 6 Apr 2006 11:16:45 -0600 [thread overview]
Message-ID: <20060406171645.GL22446@cosmic.amd.com> (raw)
In-Reply-To: <20060405221933.GN7029@enneenne.com>
On 06/04/06 00:19 +0200, Rodolfo Giometti wrote:
> Hello,
>
> here a patch to support new sysfs interface for Au1xxx's power
> management. Now we can put the system into sleeping mode by using:
>
> hostname:~# echo mem > /sys/power/state
>
> The patch keeps also the file "/proc/sys/pm/freq" from the old
> interface.
Generally looks good, thought I just glanced it over and I didn't take
it for a test run.
> /* Quick acpi hack. This will have to change! */
> -#define CTL_ACPI 9999
> -#define ACPI_S1_SLP_TYP 19
> -#define ACPI_SLEEP 21
> +#define CTL_ACPI 9999
> +#define ACPI_S1_SLP_TYP 19
> +#define ACPI_SLEEP 21
Code review comment - you have lots of minor typo fixes and whitespace
changes. You should Keep whitespace changes to a minimum, or better yet
put then in a separate patch. They detract from the actual meat of your
effort, and makes it tough to code review.
Jordan
--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>
prev parent reply other threads:[~2006-04-06 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 22:19 [PATCH] sysfs interface for Au1xxx power management Rodolfo Giometti
2006-04-06 17:16 ` Jordan Crouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060406171645.GL22446@cosmic.amd.com \
--to=jordan.crouse@amd.com \
--cc=giometti@linux.it \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.