All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	jesse.brandeburg@intel.com, linuxppc-dev@ozlabs.org,
	john.ronciak@intel.com, jeffrey.t.kirsher@intel.com,
	linux-pci@atrey.karlin.mff.cuni.cz,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] PCI Error Recovery: e100 network device driver
Date: Thu, 6 Apr 2006 15:46:43 -0700	[thread overview]
Message-ID: <20060406224643.GA6278@kroah.com> (raw)
In-Reply-To: <20060406222359.GA30037@austin.ibm.com>

On Thu, Apr 06, 2006 at 05:24:00PM -0500, Linas Vepstas wrote:
> +	if(pci_enable_device(pdev)) {

Add a space after "if" and before "(" please.

You do this in a few different places.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	netdev@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	john.ronciak@intel.com, jesse.brandeburg@intel.com,
	jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH] PCI Error Recovery: e100 network device driver
Date: Thu, 6 Apr 2006 15:46:43 -0700	[thread overview]
Message-ID: <20060406224643.GA6278@kroah.com> (raw)
In-Reply-To: <20060406222359.GA30037@austin.ibm.com>

On Thu, Apr 06, 2006 at 05:24:00PM -0500, Linas Vepstas wrote:
> +	if(pci_enable_device(pdev)) {

Add a space after "if" and before "(" please.

You do this in a few different places.

thanks,

greg k-h

  reply	other threads:[~2006-04-06 22:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-06 22:24 [PATCH] PCI Error Recovery: e100 network device driver Linas Vepstas
2006-04-06 22:24 ` Linas Vepstas
2006-04-06 22:46 ` Greg KH [this message]
2006-04-06 22:46   ` Greg KH
2006-04-07 23:11   ` Linas Vepstas
2006-04-07 23:11     ` Linas Vepstas
2006-04-08  0:03     ` Alexey Dobriyan
2006-04-08  0:03       ` Alexey Dobriyan
2006-04-08  8:12     ` Francois Romieu
2006-04-08  8:12       ` Francois Romieu
2006-04-29  2:48 ` Zhang, Yanmin
2006-04-29  2:48   ` Zhang, Yanmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060406224643.GA6278@kroah.com \
    --to=greg@kroah.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jgarzik@pobox.com \
    --cc=john.ronciak@intel.com \
    --cc=linas@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.