All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Re: [PATCH 03/17] uml: fix 2 harmless cast warnings for 64-bit
Date: Fri, 7 Apr 2006 12:02:18 -0400	[thread overview]
Message-ID: <20060407160218.GA4962@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20060407143054.19201.89200.stgit@zion.home.lan>

On Fri, Apr 07, 2006 at 04:30:54PM +0200, Paolo 'Blaisorblade' Giarrusso wrote:
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> 
> Fix two harmless warnings in 64-bit compilation (the 2nd doesn't trigger for now
> because of a missing __attribute((format)) for cow_printf, but next patches fix
> that).

I don't object to this bit, but it doesn't seem to match the comment.  Was
there another cast that you meant to have here, but missed?

> -		n = min((size_t)len, ARRAY_SIZE(console_buf) - console_index);
> +		n = min((size_t) len, ARRAY_SIZE(console_buf) - console_index);

				Jeff


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: "Paolo 'Blaisorblade' Giarrusso" <blaisorblade@yahoo.it>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 03/17] uml: fix 2 harmless cast warnings for 64-bit
Date: Fri, 7 Apr 2006 12:02:18 -0400	[thread overview]
Message-ID: <20060407160218.GA4962@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20060407143054.19201.89200.stgit@zion.home.lan>

On Fri, Apr 07, 2006 at 04:30:54PM +0200, Paolo 'Blaisorblade' Giarrusso wrote:
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> 
> Fix two harmless warnings in 64-bit compilation (the 2nd doesn't trigger for now
> because of a missing __attribute((format)) for cow_printf, but next patches fix
> that).

I don't object to this bit, but it doesn't seem to match the comment.  Was
there another cast that you meant to have here, but missed?

> -		n = min((size_t)len, ARRAY_SIZE(console_buf) - console_index);
> +		n = min((size_t) len, ARRAY_SIZE(console_buf) - console_index);

				Jeff

  reply	other threads:[~2006-04-07 17:01 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-07 14:27 [uml-devel] [PATCH 00/17] Uml little fixups for new and existing code [for 2.6.17] Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:27 ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:30 ` [uml-devel] [PATCH 01/17] uml: make 64-bit COW files compatible with 32-bit ones Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:30   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:30 ` [uml-devel] [PATCH 02/17] uml: safe migration path to the correct V3 COW format Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:30   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:30 ` [uml-devel] [PATCH 03/17] uml: fix 2 harmless cast warnings for 64-bit Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:30   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 16:02   ` Jeff Dike [this message]
2006-04-07 16:02     ` Jeff Dike
2006-04-07 21:46     ` [uml-devel] " Blaisorblade
2006-04-07 21:46       ` Blaisorblade
2006-04-07 14:30 ` [uml-devel] [PATCH 04/17] uml: request format warnings to GCC for appropriate functions Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:30   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 05/17] uml: fix format errors Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 06/17] uml: fix some double export warnings Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 07/17] uml: fix "extern-vs-static" proto conflict in TLS code Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 08/17] uml: prepare fixing compilation output Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 16:05   ` [uml-devel] " Jeff Dike
2006-04-07 16:05     ` Jeff Dike
2006-04-07 21:50     ` [uml-devel] " Blaisorblade
2006-04-07 21:50       ` Blaisorblade
2006-04-07 14:31 ` [uml-devel] [PATCH 09/17] uml: fix critical typo for TT mode Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 15:45   ` [uml-devel] " Jeff Dike
2006-04-07 15:45     ` Jeff Dike
2006-04-07 14:31 ` [uml-devel] [PATCH 10/17] uml: support sparse for userspace files Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 11/17] uml: move outside spinlock call not needing it Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 12/17] uml: fix hang on run_helper() failure on uml_net Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 13/17] uml: fix failure path after conversion Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 14/17] uml: fix big stack user Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 15/17] uml: local_irq_save, not local_save_flags Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 16/17] uml: fix parallel make early failure on clean tree Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31 ` [uml-devel] [PATCH 17/17] uml: avoid warnings for diffent names for an unsigned quadword Paolo 'Blaisorblade' Giarrusso
2006-04-07 14:31   ` Paolo 'Blaisorblade' Giarrusso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060407160218.GA4962@ccure.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=akpm@osdl.org \
    --cc=blaisorblade@yahoo.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.