From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1FRuKa-0004N8-An for user-mode-linux-devel@lists.sourceforge.net; Fri, 07 Apr 2006 10:01:08 -0700 Received: from saraswathi.solana.com ([198.99.130.12]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1FRuKW-0004JI-EN for user-mode-linux-devel@lists.sourceforge.net; Fri, 07 Apr 2006 10:01:05 -0700 From: Jeff Dike Message-ID: <20060407160218.GA4962@ccure.user-mode-linux.org> References: <20060407142709.19201.99196.stgit@zion.home.lan> <20060407143054.19201.89200.stgit@zion.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060407143054.19201.89200.stgit@zion.home.lan> Subject: [uml-devel] Re: [PATCH 03/17] uml: fix 2 harmless cast warnings for 64-bit Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Fri, 7 Apr 2006 12:02:18 -0400 To: Paolo 'Blaisorblade' Giarrusso Cc: Andrew Morton , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net On Fri, Apr 07, 2006 at 04:30:54PM +0200, Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso > > Fix two harmless warnings in 64-bit compilation (the 2nd doesn't trigger for now > because of a missing __attribute((format)) for cow_printf, but next patches fix > that). I don't object to this bit, but it doesn't seem to match the comment. Was there another cast that you meant to have here, but missed? > - n = min((size_t)len, ARRAY_SIZE(console_buf) - console_index); > + n = min((size_t) len, ARRAY_SIZE(console_buf) - console_index); Jeff ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964815AbWDGRBU (ORCPT ); Fri, 7 Apr 2006 13:01:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964816AbWDGRBU (ORCPT ); Fri, 7 Apr 2006 13:01:20 -0400 Received: from saraswathi.solana.com ([198.99.130.12]:62913 "EHLO saraswathi.solana.com") by vger.kernel.org with ESMTP id S964815AbWDGRBT (ORCPT ); Fri, 7 Apr 2006 13:01:19 -0400 Date: Fri, 7 Apr 2006 12:02:18 -0400 From: Jeff Dike To: "Paolo 'Blaisorblade' Giarrusso" Cc: Andrew Morton , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [PATCH 03/17] uml: fix 2 harmless cast warnings for 64-bit Message-ID: <20060407160218.GA4962@ccure.user-mode-linux.org> References: <20060407142709.19201.99196.stgit@zion.home.lan> <20060407143054.19201.89200.stgit@zion.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060407143054.19201.89200.stgit@zion.home.lan> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2006 at 04:30:54PM +0200, Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso > > Fix two harmless warnings in 64-bit compilation (the 2nd doesn't trigger for now > because of a missing __attribute((format)) for cow_printf, but next patches fix > that). I don't object to this bit, but it doesn't seem to match the comment. Was there another cast that you meant to have here, but missed? > - n = min((size_t)len, ARRAY_SIZE(console_buf) - console_index); > + n = min((size_t) len, ARRAY_SIZE(console_buf) - console_index); Jeff