All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nullify __ide_flush_{prologue,epilogue} on UP
@ 2006-04-07 16:25 Atsushi Nemoto
  2006-04-07 16:38 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2006-04-07 16:25 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

diff --git a/include/asm-mips/mach-generic/ide.h b/include/asm-mips/mach-generic/ide.h
index 44266e5..e331535 100644
--- a/include/asm-mips/mach-generic/ide.h
+++ b/include/asm-mips/mach-generic/ide.h
@@ -106,14 +106,18 @@ static __inline__ unsigned long ide_defa
 /* MIPS port and memory-mapped I/O string operations.  */
 static inline void __ide_flush_prologue(void)
 {
+#ifdef CONFIG_SMP
 	if (cpu_has_dc_aliases)
 		preempt_disable();
+#endif
 }
 
 static inline void __ide_flush_epilogue(void)
 {
+#ifdef CONFIG_SMP
 	if (cpu_has_dc_aliases)
 		preempt_enable();
+#endif
 }
 
 static inline void __ide_flush_dcache_range(unsigned long addr, unsigned long size)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] nullify __ide_flush_{prologue,epilogue} on UP
  2006-04-07 16:25 [PATCH] nullify __ide_flush_{prologue,epilogue} on UP Atsushi Nemoto
@ 2006-04-07 16:38 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2006-04-07 16:38 UTC (permalink / raw)
  To: Atsushi Nemoto; +Cc: linux-mips

On Sat, Apr 08, 2006 at 01:25:11AM +0900, Atsushi Nemoto wrote:

> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

Looks good, applied.

Actually I have my objections wrt to shared caches such as with SMP on
the 34K but that's another project.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-04-07 16:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-07 16:25 [PATCH] nullify __ide_flush_{prologue,epilogue} on UP Atsushi Nemoto
2006-04-07 16:38 ` Ralf Baechle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.