* [2.6 patch] drivers/isdn/capi/capiutil.c: unexport capi_message2str
@ 2006-04-07 21:17 Adrian Bunk
2006-04-09 13:07 ` Karsten Keil
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-04-07 21:17 UTC (permalink / raw)
To: kkeil; +Cc: isdn4linux, linux-kernel
This patch removes an unused EXPORT_SYMBOL.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.17-rc1-mm1-full/drivers/isdn/capi/capiutil.c.old 2006-04-07 10:47:30.000000000 +0200
+++ linux-2.6.17-rc1-mm1-full/drivers/isdn/capi/capiutil.c 2006-04-07 10:47:37.000000000 +0200
@@ -855,5 +855,4 @@
EXPORT_SYMBOL(capi_cmsg_header);
EXPORT_SYMBOL(capi_cmd2str);
EXPORT_SYMBOL(capi_cmsg2str);
-EXPORT_SYMBOL(capi_message2str);
EXPORT_SYMBOL(capi_info2str);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/isdn/capi/capiutil.c: unexport capi_message2str
2006-04-07 21:17 [2.6 patch] drivers/isdn/capi/capiutil.c: unexport capi_message2str Adrian Bunk
@ 2006-04-09 13:07 ` Karsten Keil
2006-04-09 15:02 ` Arjan van de Ven
0 siblings, 1 reply; 3+ messages in thread
From: Karsten Keil @ 2006-04-09 13:07 UTC (permalink / raw)
To: Adrian Bunk; +Cc: isdn4linux, linux-kernel
On Fri, Apr 07, 2006 at 11:17:36PM +0200, Adrian Bunk wrote:
> This patch removes an unused EXPORT_SYMBOL.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.17-rc1-mm1-full/drivers/isdn/capi/capiutil.c.old 2006-04-07 10:47:30.000000000 +0200
> +++ linux-2.6.17-rc1-mm1-full/drivers/isdn/capi/capiutil.c 2006-04-07 10:47:37.000000000 +0200
> @@ -855,5 +855,4 @@
> EXPORT_SYMBOL(capi_cmsg_header);
> EXPORT_SYMBOL(capi_cmd2str);
> EXPORT_SYMBOL(capi_cmsg2str);
> -EXPORT_SYMBOL(capi_message2str);
> EXPORT_SYMBOL(capi_info2str);
>
Yes it is currently unused, but part of the CAPI driver SDK for supporting
debug messages in capi drivers, so I would tend to let it exported, if here
are not strong arguments against exporting it.
--
Karsten Keil
SuSE Labs
ISDN development
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/isdn/capi/capiutil.c: unexport capi_message2str
2006-04-09 13:07 ` Karsten Keil
@ 2006-04-09 15:02 ` Arjan van de Ven
0 siblings, 0 replies; 3+ messages in thread
From: Arjan van de Ven @ 2006-04-09 15:02 UTC (permalink / raw)
To: Karsten Keil; +Cc: Adrian Bunk, isdn4linux, linux-kernel
On Sun, 2006-04-09 at 15:07 +0200, Karsten Keil wrote:
> On Fri, Apr 07, 2006 at 11:17:36PM +0200, Adrian Bunk wrote:
> > This patch removes an unused EXPORT_SYMBOL.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > --- linux-2.6.17-rc1-mm1-full/drivers/isdn/capi/capiutil.c.old 2006-04-07 10:47:30.000000000 +0200
> > +++ linux-2.6.17-rc1-mm1-full/drivers/isdn/capi/capiutil.c 2006-04-07 10:47:37.000000000 +0200
> > @@ -855,5 +855,4 @@
> > EXPORT_SYMBOL(capi_cmsg_header);
> > EXPORT_SYMBOL(capi_cmd2str);
> > EXPORT_SYMBOL(capi_cmsg2str);
> > -EXPORT_SYMBOL(capi_message2str);
> > EXPORT_SYMBOL(capi_info2str);
> >
>
> Yes it is currently unused, but part of the CAPI driver SDK for supporting
> debug messages in capi drivers, so I would tend to let it exported, if here
> are not strong arguments against exporting it.
every export takes space in the binary kernel. There's some 900 of these
unused ones, totalling to about 100Kb of unused bloat.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-04-09 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-07 21:17 [2.6 patch] drivers/isdn/capi/capiutil.c: unexport capi_message2str Adrian Bunk
2006-04-09 13:07 ` Karsten Keil
2006-04-09 15:02 ` Arjan van de Ven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.