From: Timo Hirvonen <tihirvon@gmail.com>
To: git@vger.kernel.org
Cc: torvalds@osdl.org, junkio@cox.net, git@vger.kernel.org
Subject: Re: [PATCH] git log [diff-tree options]...
Date: Mon, 10 Apr 2006 01:22:58 +0300 [thread overview]
Message-ID: <20060410012258.589f1581.tihirvon@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0604100000430.30000@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> +static int cmd_whatchanged(int argc, const char **argv, char **envp)
> +{
> + memmove(argv + 2, argv + 1, argc - 1);
Shouldn't the size be sizeof(char *) * argc (NULL terminated array)?
There's also overflow...
--
http://onion.dynserv.net/~timo/
next prev parent reply other threads:[~2006-04-09 22:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-09 9:04 [PATCH] git log [diff-tree options] Junio C Hamano
2006-04-09 9:16 ` Junio C Hamano
2006-04-09 16:53 ` Linus Torvalds
2006-04-09 18:46 ` Junio C Hamano
2006-04-09 19:02 ` Linus Torvalds
2006-04-09 19:08 ` Junio C Hamano
2006-04-09 19:26 ` Linus Torvalds
2006-04-09 21:13 ` Johannes Schindelin
2006-04-09 22:01 ` Johannes Schindelin
2006-04-09 22:22 ` Timo Hirvonen [this message]
2006-04-10 8:10 ` Johannes Schindelin
2006-04-09 23:51 ` Junio C Hamano
2006-04-10 0:06 ` Linus Torvalds
2006-04-10 8:22 ` Johannes Schindelin
2006-04-11 0:04 ` Randal L. Schwartz
2006-04-11 0:12 ` Junio C Hamano
2006-04-11 0:31 ` Petr Baudis
2006-04-11 0:50 ` Randal L. Schwartz
2006-04-10 23:42 ` Junio C Hamano
2006-04-10 23:43 ` [PATCH] tree-diff: do not assume we use only one pathspec Junio C Hamano
2006-04-10 23:44 ` [PATCH] git log --full-diff Junio C Hamano
2006-04-10 23:54 ` [PATCH] git log [diff-tree options] Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060410012258.589f1581.tihirvon@gmail.com \
--to=tihirvon@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.