From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Massimiliano Galanti <massiblue@libero.it>
Cc: linux-mtd@lists.infradead.org
Subject: Re: checking write_cached_data return status inside _release and _flush?
Date: Mon, 10 Apr 2006 12:02:52 +0200 [thread overview]
Message-ID: <20060410100252.GA17383@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <4436A961.7050209@libero.it>
On Fri, 7 April 2006 20:03:13 +0200, Massimiliano Galanti wrote:
>
> i experienced some corruption of data on flash memories i am using, and
> discovered that this is related to these functions in mtdblock.c:
>
> static int mtdblock_release(struct mtd_blktrans_dev *mbd)
> static int mtdblock_flush(struct mtd_blktrans_dev *dev)
>
> not checking the return value of the function:
>
> write_cached_data(mtdblk)
>
> i fixed that by checking the return value inside a while cycle but is
> there any particular reason the original code is written that way?
Sounds like a plain bug. Can you send a patch?
Jörn
--
If you're willing to restrict the flexibility of your approach,
you can almost always do something better.
-- John Carmack
next prev parent reply other threads:[~2006-04-10 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 18:03 checking write_cached_data return status inside _release and _flush? Massimiliano Galanti
2006-04-10 10:02 ` Jörn Engel [this message]
[not found] <IXI8OW$25AAA6D68166E4BF09ED12F6E5747466@libero.it>
2006-04-10 12:24 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060410100252.GA17383@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=linux-mtd@lists.infradead.org \
--cc=massiblue@libero.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.