* [Patch] leak in net/dccp/ipv4.c
@ 2006-04-10 22:07 Eric Sesterhenn
2006-04-10 23:43 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sesterhenn @ 2006-04-10 22:07 UTC (permalink / raw)
To: LKML; +Cc: acme
hi,
we dont free req if we cant parse the options.
This fixes coverity bug id #1046
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc1/net/dccp/ipv4.c.orig 2006-04-11 00:05:39.000000000 +0200
+++ linux-2.6.17-rc1/net/dccp/ipv4.c 2006-04-11 00:06:08.000000000 +0200
@@ -498,7 +498,7 @@ int dccp_v4_conn_request(struct sock *sk
goto drop;
if (dccp_parse_options(sk, skb))
- goto drop;
+ goto drop_and_free;
dccp_openreq_init(req, &dp, skb);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] leak in net/dccp/ipv4.c
2006-04-10 22:07 [Patch] leak in net/dccp/ipv4.c Eric Sesterhenn
@ 2006-04-10 23:43 ` David S. Miller
2006-04-11 0:04 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2006-04-10 23:43 UTC (permalink / raw)
To: snakebyte; +Cc: linux-kernel, acme
From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Tue, 11 Apr 2006 00:07:26 +0200
> we dont free req if we cant parse the options.
> This fixes coverity bug id #1046
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Looks good.
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] leak in net/dccp/ipv4.c
2006-04-10 23:43 ` David S. Miller
@ 2006-04-11 0:04 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2006-04-11 0:04 UTC (permalink / raw)
To: David S. Miller; +Cc: snakebyte, linux-kernel
Em Mon, Apr 10, 2006 at 04:43:16PM -0700, David S. Miller escreveu:
> From: Eric Sesterhenn <snakebyte@gmx.de>
> Date: Tue, 11 Apr 2006 00:07:26 +0200
>
> > we dont free req if we cant parse the options.
> > This fixes coverity bug id #1046
> >
> > Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> Looks good.
>
> Applied, thanks Eric.
Thanks everybody.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-04-11 0:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-10 22:07 [Patch] leak in net/dccp/ipv4.c Eric Sesterhenn
2006-04-10 23:43 ` David S. Miller
2006-04-11 0:04 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.