From: Adrian Bunk <bunk@stusta.de>
To: chris@zankel.net
Cc: Russell King <rmk+lkml@arm.linux.org.uk>, linux-kernel@vger.kernel.org
Subject: [BUG] sizeof(struct async_icount) exported to userspace on SH, SH64 and xtensa (fwd)
Date: Tue, 11 Apr 2006 03:30:36 +0200 [thread overview]
Message-ID: <20060411013036.GA3190@stusta.de> (raw)
Chris,
now that the sh people have fixed it on their ports, xtensa is the only
port with this issue.
Please fix it.
TIA
Adrian
----- Forwarded message from Russell King <rmk+lkml@arm.linux.org.uk> -----
Date: Sat, 21 Jan 2006 18:57:12 +0000
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linux Kernel List <linux-kernel@vger.kernel.org>
Cc: chris@zankel.net, lethal@linux-sh.org
Subject: [BUG] sizeof(struct async_icount) exported to userspace on SH, SH64 and xtensa
I've just been looking through the remaining cruft in the serial
drivers, and have come across this silly thing:
TIOCGICOUNT exports a structure to userspace called
struct serial_icounter_struct.
However, sh, sh64 and xtensa do this:
include/asm-sh/ioctls.h:#define TIOCGICOUNT _IOR('T', 93, struct async_icount) /* 0x545D */ /* read serial port inline interrupt counts */
include/asm-sh64/ioctls.h:#define TIOCGICOUNT 0x802c545d /* _IOR('T', 93, struct async_icount) 0x545D */ /* read serial port inline interrupt counts */
include/asm-xtensa/ioctls.h:#define TIOCGICOUNT _IOR('T', 93, struct async_icount) /* read serial port inline interrupt counts */
What's more is that no driver actually exports async_icount, and
async_icount is a kernel internal structure which does _not_ form
part of the public API, and modifications to this will result in
unexpected breakage on these platforms.
100% for trying to clean up the tty ioctl definitions. 0% for
using the wrong structures. As such, these _require_ fixing.
Please document that your TIOCGICOUNT is broken and remove the
dependence on the async_icount structure. Thanks.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
----- End forwarded message -----
reply other threads:[~2006-04-11 1:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060411013036.GA3190@stusta.de \
--to=bunk@stusta.de \
--cc=chris@zankel.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.