From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932229AbWDKGWQ (ORCPT ); Tue, 11 Apr 2006 02:22:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932230AbWDKGWQ (ORCPT ); Tue, 11 Apr 2006 02:22:16 -0400 Received: from mail.tv-sign.ru ([213.234.233.51]:32185 "EHLO several.ru") by vger.kernel.org with ESMTP id S932229AbWDKGWP (ORCPT ); Tue, 11 Apr 2006 02:22:15 -0400 Date: Tue, 11 Apr 2006 14:19:23 +0400 From: Oleg Nesterov To: Ingo Oeser Cc: "Eric W. Biederman" , Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] de_thread: Don't confuse users do_each_thread. Message-ID: <20060411101923.GB112@oleg> References: <20060406220403.GA205@oleg> <200604110152.38861.ioe-lkml@rameria.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200604110152.38861.ioe-lkml@rameria.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 04/11, Ingo Oeser wrote: > > While you are at it: Could you please avoid calculating current over > and over again? > > Just calculate it once and use the task_struct pointer. Ironically, de_thread() has 'tsk' parameter which is equal to 'current'. Oleg.