From: Andrew Morton <akpm@osdl.org>
To: Kylene Jo Hall <kjhall@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/7] tpm: reorganize sysfs files - Updated patch
Date: Tue, 11 Apr 2006 11:18:34 -0700 [thread overview]
Message-ID: <20060411111834.587e4461.akpm@osdl.org> (raw)
In-Reply-To: <1144765495.4917.25.camel@localhost.localdomain>
Kylene Jo Hall <kjhall@us.ibm.com> wrote:
>
> > Does that look OK?
>
> No this is not ok because in several of these cases the response to the
> command is longer than tpm_cap thus the reason for the hardcoded size.
OK.
> I can put in a max function though that compares the size of the
> response and the tpm_cap. The read functions will make sure the
> response does not overflow the buffer should that length ever change in
> the future.
Well, pretty much anything which will automatically increase the size of
that array in response to changing data structures would suit, thanks.
next prev parent reply other threads:[~2006-04-11 19:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 14:37 [PATCH 2/7] tpm: reorganize sysfs files - Updated patch Kylene Jo Hall
2006-04-10 21:46 ` Andrew Morton
2006-04-11 14:24 ` Kylene Jo Hall
2006-04-11 18:18 ` Andrew Morton [this message]
2006-04-11 20:15 ` [PATCH] tpm: sysfs function buffer size fix Kylene Jo Hall
2006-04-11 20:45 ` Ingo Oeser
2006-04-11 21:05 ` Kylene Jo Hall
2006-04-11 22:32 ` [PATCH] tpm: compiler cleanup Kylene Jo Hall
-- strict thread matches above, loose matches on Subject: below --
2006-04-05 19:48 [PATCH 2/7] tpm: reorganize sysfs files - Updated patch Kylene Jo Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060411111834.587e4461.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.