All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matt T. Yourst" <yourst@yourst.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: yourst@cs.binghamton.edu, xen-devel@lists.xensource.com
Subject: Re: Xen cpufreq support status: how to notify hypervisor of frequency change?
Date: Tue, 11 Apr 2006 16:11:42 -0400	[thread overview]
Message-ID: <200604111611.42604.yourst@yourst.com> (raw)
In-Reply-To: <a7b85d7918d7286e32020eb4abd1ee37@cl.cam.ac.uk>

On Tuesday 11 April 2006 04:25 am, Keir Fraser wrote:
>
> All this stuff should be done by emulating the MSR writes in
> emulate_privileged_op() in arch/x86/traps.c. This will avoid any
> modification of Linux at all. Currently there's only simple filtering
> of MSR write attempts, but picking up on cpu-freq MSR accesses on e.g.,
> AMD systems and also resync'ing the local clock would not be difficult.
>

I'll give this a try - it should be much cleaner than my current method and 
may avoid some race issues (see below).

We may need to duplicate some work done by the dom0 kernel and read out the 
frequency/voltage tables, since the MSR write on AMD chips (and probably 
Intel) does not specify an actual "XXX MHz" number - it's just an index into 
the FID/VID table. I'll investigate this, but I need someone with an Intel 
chip to do the same, since I have no way of testing those MSRs.

I'm still getting some issues with the timer not properly re-syncing even 
though the cpufreq driver makes the new setcpufreq hypercall, which Xen 
properly receives.

Right now it just sets cpu_khz and calls local_time_calibration() on the 
target CPU(s). Is there something else we need to do, like calling the 
equivalent of early_time_init() or init_xen_time() all over again?

The problem is much less severe now but it still sometimes happens.

- Matt

-------------------------------------------------------
 Matt T. Yourst               yourst@cs.binghamton.edu
 Binghamton University, Department of Computer Science
-------------------------------------------------------

  reply	other threads:[~2006-04-11 20:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-08 22:29 Xen cpufreq support status: how to notify hypervisor of frequency change? Matt T. Yourst
2006-04-10 14:01 ` Keir Fraser
2006-04-11  0:05   ` Matt T. Yourst
2006-04-11  8:25     ` Keir Fraser
2006-04-11 20:11       ` Matt T. Yourst [this message]
2006-04-12  5:47         ` Keir Fraser
2006-04-13  2:31           ` Matt T. Yourst
2006-04-13 10:44             ` Keir Fraser
2006-04-13 18:28               ` Matt T. Yourst
2006-04-14  6:44                 ` Keir Fraser
2006-04-12  2:49       ` Matt T. Yourst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200604111611.42604.yourst@yourst.com \
    --to=yourst@yourst.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    --cc=yourst@cs.binghamton.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.