From: Christoph Hellwig <hch@lst.de>
To: Jake Moilanen <moilanen@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 1/2] Base pSeries PCIe support
Date: Wed, 12 Apr 2006 06:06:35 +0200 [thread overview]
Message-ID: <20060412040635.GB7870@lst.de> (raw)
In-Reply-To: <20060331160545.db3fa210.moilanen@austin.ibm.com>
On Fri, Mar 31, 2006 at 04:05:45PM -0600, Jake Moilanen wrote:
> +source "drivers/pci/pcie/Kconfig"
does it actually work on ppc64? last time I checked that code was
utterly x86-centric.
> - if (node->type == NULL || strcmp(node->type, "pci") != 0)
> +
> + if (node->type == NULL || ((strcmp(node->type, "pci") != 0) && (strcmp(node->type, "pciex") != 0)))
> continue;
please don't add superflous braces
next prev parent reply other threads:[~2006-04-12 4:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 22:02 [PATCH 0/2] Base pSeries PCIe support Jake Moilanen
2006-03-31 22:05 ` [PATCH 1/2] " Jake Moilanen
2006-03-31 22:15 ` Dave Hansen
2006-03-31 22:18 ` Jake Moilanen
2006-04-12 4:06 ` Christoph Hellwig [this message]
2006-03-31 22:13 ` [PATCH 2/2] " Jake Moilanen
2006-03-31 22:48 ` Olof Johansson
2006-03-31 23:08 ` Olof Johansson
2006-04-01 8:36 ` Paul Mackerras
2006-04-01 22:57 ` Jake Moilanen
2006-04-10 15:39 ` Jake Moilanen
2006-04-11 21:31 ` Benjamin Herrenschmidt
2006-04-01 8:38 ` Paul Mackerras
2006-04-12 4:05 ` Christoph Hellwig
2006-03-31 22:28 ` [PATCH 0/2] " Arnd Bergmann
2006-03-31 22:35 ` Jake Moilanen
2006-03-31 22:39 ` Doug Maxey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060412040635.GB7870@lst.de \
--to=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=moilanen@austin.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.