From: Lubomir Kundrak <lkundrak@skosi.org>
To: grub-devel@gnu.org
Subject: Re: [patch] strncpy misuse in ufs.c]
Date: Wed, 12 Apr 2006 08:06:30 +0200 [thread overview]
Message-ID: <20060412060630.GG48945@meta.morph.sk> (raw)
In-Reply-To: <20060411120822.GF48945@meta.morph.sk>
EEh.... should actually read
--- ufs.c.orig 2006-04-10 12:17:10.000000000 +0200
+++ ufs.c 2006-04-10 12:17:32.000000000 +0200
@@ -400,7 +400,7 @@
unsigned int pos = 0;
int dirino;
- grub_strncpy (fpath, path, grub_strlen (path));
+ grub_strncpy (fpath, path, sizeof (fpath)+);
/* Skip the first slash. */
if (name[0] == '/')
On Tue, Apr 11, 2006 at 02:08:22PM +0200, Lubomir Kundrak wrote:
> X-Original-To: lkundrak@skosi.org
> Delivered-To: lkundrak@morph.sk
> Date: Tue, 11 Apr 2006 14:08:22 +0200
> From: Lubomir Kundrak <lkundrak@skosi.org>
> To: grub-devel@gnu.org
> Mail-Followup-To: Lubomir Kundrak <lkundrak@skosi.org>, grub-devel@gnu.org
> User-Agent: Mutt/1.4.2.1i
> Subject: [patch] strncpy misuse in ufs.c]
> X-BeenThere: grub-devel@gnu.org
> X-Mailman-Version: 2.1.5
> Precedence: list
> Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
> List-Id: The development of GRUB 2 <grub-devel.gnu.org>
> List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
> <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
> List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
> List-Post: <mailto:grub-devel@gnu.org>
> List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
> List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
> <mailto:grub-devel-request@gnu.org?subject=subscribe>
> Errors-To: grub-devel-bounces+lkundrak=skosi.org@gnu.org
>
> Now again, to correct list.
> Below is the little fix for fs/ufs.c
>
> --- ufs.c.orig 2006-04-10 12:17:10.000000000 +0200
> +++ ufs.c 2006-04-10 12:17:32.000000000 +0200
> @@ -400,7 +400,7 @@
> unsigned int pos = 0;
> int dirino;
>
> - grub_strncpy (fpath, path, grub_strlen (path));
> + grub_strncpy (fpath, path, grub_strlen (path)+1);
>
> /* Skip the first slash. */
> if (name[0] == '/')
>
> regards,
> lubo
>
> --
> o Lubomir Kundrak
> *O* <lkundrak@skosi.org>, http://skosi.org/~lkundrak/
> (_) SKOSI -- Slovak OpenSource Initiative
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
o Lubomir Kundrak
*O* <lkundrak@skosi.org>, http://skosi.org/~lkundrak/
(_) SKOSI -- Slovak OpenSource Initiative
next prev parent reply other threads:[~2006-04-12 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 12:08 [patch] strncpy misuse in ufs.c] Lubomir Kundrak
2006-04-12 6:06 ` Lubomir Kundrak [this message]
2006-04-12 8:29 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060412060630.GG48945@meta.morph.sk \
--to=lkundrak@skosi.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.