From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1FTYV0-00089Z-5d for mharc-grub-devel@gnu.org; Wed, 12 Apr 2006 02:06:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FTYUy-00086v-9p for grub-devel@gnu.org; Wed, 12 Apr 2006 02:06:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FTYUw-00083z-0V for grub-devel@gnu.org; Wed, 12 Apr 2006 02:06:39 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FTYUv-00083h-PO for grub-devel@gnu.org; Wed, 12 Apr 2006 02:06:37 -0400 Received: from [147.175.55.175] (helo=meta.morph.sk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FTYZx-0007Uf-F8 for grub-devel@gnu.org; Wed, 12 Apr 2006 02:11:49 -0400 Received: by meta.morph.sk (Postfix, from userid 1018) id DD7C8445; Wed, 12 Apr 2006 08:06:30 +0200 (CEST) Date: Wed, 12 Apr 2006 08:06:30 +0200 From: Lubomir Kundrak To: grub-devel@gnu.org Message-ID: <20060412060630.GG48945@meta.morph.sk> Mail-Followup-To: Lubomir Kundrak , grub-devel@gnu.org References: <20060411120822.GF48945@meta.morph.sk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060411120822.GF48945@meta.morph.sk> User-Agent: Mutt/1.4.2.1i Subject: Re: [patch] strncpy misuse in ufs.c] X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2006 06:06:40 -0000 EEh.... should actually read --- ufs.c.orig 2006-04-10 12:17:10.000000000 +0200 +++ ufs.c 2006-04-10 12:17:32.000000000 +0200 @@ -400,7 +400,7 @@ unsigned int pos = 0; int dirino; - grub_strncpy (fpath, path, grub_strlen (path)); + grub_strncpy (fpath, path, sizeof (fpath)+); /* Skip the first slash. */ if (name[0] == '/') On Tue, Apr 11, 2006 at 02:08:22PM +0200, Lubomir Kundrak wrote: > X-Original-To: lkundrak@skosi.org > Delivered-To: lkundrak@morph.sk > Date: Tue, 11 Apr 2006 14:08:22 +0200 > From: Lubomir Kundrak > To: grub-devel@gnu.org > Mail-Followup-To: Lubomir Kundrak , grub-devel@gnu.org > User-Agent: Mutt/1.4.2.1i > Subject: [patch] strncpy misuse in ufs.c] > X-BeenThere: grub-devel@gnu.org > X-Mailman-Version: 2.1.5 > Precedence: list > Reply-To: The development of GRUB 2 > List-Id: The development of GRUB 2 > List-Unsubscribe: , > > List-Archive: > List-Post: > List-Help: > List-Subscribe: , > > Errors-To: grub-devel-bounces+lkundrak=skosi.org@gnu.org > > Now again, to correct list. > Below is the little fix for fs/ufs.c > > --- ufs.c.orig 2006-04-10 12:17:10.000000000 +0200 > +++ ufs.c 2006-04-10 12:17:32.000000000 +0200 > @@ -400,7 +400,7 @@ > unsigned int pos = 0; > int dirino; > > - grub_strncpy (fpath, path, grub_strlen (path)); > + grub_strncpy (fpath, path, grub_strlen (path)+1); > > /* Skip the first slash. */ > if (name[0] == '/') > > regards, > lubo > > -- > o Lubomir Kundrak > *O* , http://skosi.org/~lkundrak/ > (_) SKOSI -- Slovak OpenSource Initiative > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- o Lubomir Kundrak *O* , http://skosi.org/~lkundrak/ (_) SKOSI -- Slovak OpenSource Initiative