Re: net interface renaming issue (+fix?)

[md@Linux.IT (Marco d'Itri)]

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

On Apr 13, Kay Sievers <kay.sievers@vrfy.org> wrote:

> But right, the longer term goal is that the notion of "physical devices"
> and "virtual devices" should not be exported that way by the kernel
> and therefore the use of these values, or the "device" link, or the
> <subsystem:kernel_name> symlinks, or a hardcoded sequence of sysfs parent
> devices must be avoided for other things than temporary workarounds.

How should I rewrite this code then?

device_description() {
  local bus=$(sysreadlink device/bus)
  bus=${bus##*/}

  if   [ "$bus" = pci ]; then
    local vendor_id=$(sysread device/vendor)
    local device_id=$(sysread device/device)
    echo -n "PCI device ${vendor_id#0x}:${device_id#0x}"
  elif [ "$bus" = usb ]; then
    local device=$(sysreadlink device)
    if [ "$device" -a -e $device/../idVendor ]; then
      local idVendor idProduct
      read idVendor  < $device/../idVendor  || true
      read idProduct < $device/../idProduct || true
      printf 'USB device %x/%x' 0x$idVendor 0x$idProduct
    else
      echo -n "UNKNOWN USB device ($DEVPATH)"
    fi
  elif [ "$bus" ]; then
    echo -n "UNKNOWN $bus device ($DEVPATH)"
  else
    echo -n "UNKNOWN device ($DEVPATH)"
  fi

  local driver=$(sysreadlink device/driver)
  if [ "$driver" ]; then echo -n " (${driver##*/})"; fi
}

-- 
ciao,
Marco

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]