From: Roger Luethi <rl@hellgate.ch>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Marco Berizzi <pupilla@hotmail.com>,
netdev@vger.kernel.org
Subject: Re: via_rhine modules error on 2.6.16 with mii-tool
Date: Thu, 13 Apr 2006 22:47:31 +0200 [thread overview]
Message-ID: <20060413204731.GB2874@k3.hellgate.ch> (raw)
In-Reply-To: <20060413114018.65fba555@localhost.localdomain>
On Thu, 13 Apr 2006 11:40:18 -0700, Stephen Hemminger wrote:
> The right thing to do is get rid of the locking in via_rhine:netdev_ioctl
> and push the locking down into mdio_read, mdio_write.
As I said before, a dozen other network drivers do the exact same thing --
they call generic_mii_ioctl right after grabbing the private spin lock (and
only one driver calls generic_mii_ioctl without taking the lock).
I am not keen on patches that make via-rhine more of a special case even if
it was safe now; next thing you know generic_mii_ioctl is changed in a way
that breaks the only driver that foolishly made assumptions about the
side-effects of that function.
If you can safely move the locking down for all network drivers, that would
be a different story, of course.
Roger
next prev parent reply other threads:[~2006-04-13 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BAY103-F401F96F0B06D75E70AF0BFB2DF0@phx.gbl>
[not found] ` <20060327203946.GA11824@k3.hellgate.ch>
2006-04-13 18:26 ` via_rhine modules error on 2.6.16 with mii-tool John W. Linville
2006-04-13 18:40 ` Stephen Hemminger
2006-04-13 20:47 ` Roger Luethi [this message]
2006-04-13 21:02 ` Stephen Hemminger
2006-04-13 21:36 ` Francois Romieu
2006-04-13 21:55 ` Roger Luethi
2006-04-13 20:31 ` Roger Luethi
2006-05-19 14:41 ` [patch] via-rhine: revert "change mdelay to msleep and remove from ISR path" John W. Linville
2006-05-19 14:51 ` [patch w/o fuzz] " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060413204731.GB2874@k3.hellgate.ch \
--to=rl@hellgate.ch \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pupilla@hotmail.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.