From mboxrd@z Thu Jan 1 00:00:00 1970 From: Horms Subject: Re: [PATCH 11/11] build: Don't assume that mkbuildtree is executable Date: Fri, 14 Apr 2006 10:44:20 +0900 Message-ID: <20060414014419.GA28523@verge.net.au> References: <20060410022914.15477.13677.sendpatchset@tabatha.lab.ultramonkey.org> <20060410023009.15477.66080.sendpatchset@tabatha.lab.ultramonkey.org> <20060411012324.GA5979@verge.net.au> <006d95f04460cc89da1845d12d8a16f7@cl.cam.ac.uk> <20060411085031.GJ17513@verge.net.au> <44c763b0817dc86644cb1036123b6e20@cl.cam.ac.uk> <20060413022220.GA31092@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Magnus Damm , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Apr 13, 2006 at 11:21:55AM +0100, Keir Fraser wrote: > > On 13 Apr 2006, at 03:22, Horms wrote: > > >>>Understood, if they are indeed all using /bin/bash at the moment. It > >>>seems as well to just specify bash. It can be made more flexible if > >>>the > >>>need arises. Here is an updated patch. > >> > >>Let's not risk any regressions: it should be /bin/bash, and apart from > >>the configurability argument it's also cleaner imo to define a wrapper > >>variable for /bin/bash in Config.mk. > > > >Understood > > That turns out quite ugly doesn't it... maybe I prefer the previous > patch (just use bash) after all. I guess bash will always be findable > via PATH anyway, and we *know* we need bash, so selecting a different > shell would not be a good idea. I'm comfortable either way, so please use whichever you prefer. -- Horms