From: Stephen Hemminger <shemminger@osdl.org>
To: Zhu Yi <yi.zhu@intel.com>
Cc: netdev@vger.kernel.org, "John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs
Date: Fri, 14 Apr 2006 09:33:07 -0700 [thread overview]
Message-ID: <20060414093307.3ff1c016@localhost.localdomain> (raw)
In-Reply-To: <1144991911.968.157.camel@debian.sh.intel.com>
On Fri, 14 Apr 2006 13:18:31 +0800
Zhu Yi <yi.zhu@intel.com> wrote:
> On Thu, 2006-04-13 at 10:30 -0700, Stephen Hemminger wrote:
> > Please get rid of the debug config option. Make the debug code, default
> > off and be low enough impact that everyone can ship with it.
>
> This patch is exactly doing so. There won't be the debug module param if
> CONFIG_IPW2200_DEBUG is not defined. Otherwise it could be used to set
> different debug level, which helps a lot for the driver debuging.
>
I meant get rid of CONFIG_IPW2200_DEBUG completely. Having the debug code isn't
bad, and there is no reason not to have it always there.
next prev parent reply other threads:[~2006-04-14 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 9:14 [PATCH] ipw2100: wraps the debug module param within #ifdefs Zhu Yi
2006-04-13 17:30 ` Stephen Hemminger
2006-04-14 5:18 ` Zhu Yi
2006-04-14 16:33 ` Stephen Hemminger [this message]
2006-04-17 2:17 ` Zhu Yi
2006-04-17 16:24 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060414093307.3ff1c016@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.