From: Sam Ravnborg <sam@ravnborg.org>
To: Dustin Kirkland <dustin.kirkland@us.ibm.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Kylene Jo Hall <kjhall@us.ibm.com>,
kbuild-devel@lists.sourceforge.net,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] make: add modules_update target
Date: Sat, 15 Apr 2006 10:40:58 +0200 [thread overview]
Message-ID: <20060415084058.GA29502@mars.ravnborg.org> (raw)
In-Reply-To: <1145061219.4001.25.camel@localhost.localdomain>
On Fri, Apr 14, 2006 at 07:33:39PM -0500, Dustin Kirkland wrote:
> It looks like it may not be easy to drop in modules_update as a more
> efficient alternative to modules_install, but note that is not the patch
> that Kylie submitted...
The problem to be solved is the long time it takes to do
"make modules_install" when working on a single module.
Instead of bringing in more or less complex solutions what about
extending "make dir/module.ko" to include the installation of the
module.
Something like:
"make MI=1 dir/module.ko"
where MI=1 tells us to install the said module.
I'm not particular found of the syntax - anyone with a better proposal?
Untested sample patch below.
Sam
diff --git a/Makefile b/Makefile
index fc8e08c..0c0649c 100644
--- a/Makefile
+++ b/Makefile
@@ -1312,6 +1312,11 @@ # Modules
$(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \
$(build)=$(build-dir) $(@:.ko=.o)
$(Q)$(MAKE) -rR -f $(srctree)/scripts/Makefile.modpost
+ifneq ($(MI),)
+ cp $@ $(MODLIB)/kernel/$(dir $@)
+ if [ -r System.map -a -x $(DEPMOD) ]; then \
+ $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE); fi
+endif
# FIXME Should go into a make.lib or something
# ===========================================================================
next prev parent reply other threads:[~2006-04-15 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 15:06 [PATCH] make: add modules_update target Kylene Jo Hall
2006-04-14 17:02 ` Theodore Ts'o
2006-04-14 18:00 ` Avi Kivity
2006-04-14 18:29 ` Dustin Kirkland
2006-04-14 19:02 ` Avi Kivity
2006-04-15 0:33 ` Dustin Kirkland
2006-04-15 0:33 ` Dustin Kirkland
2006-04-15 8:40 ` Sam Ravnborg [this message]
2006-04-15 15:02 ` Theodore Ts'o
2006-04-16 18:24 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060415084058.GA29502@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=dustin.kirkland@us.ibm.com \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.