From: Dave Jones <davej@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Improve PCI config space writeback.
Date: Sun, 16 Apr 2006 20:16:42 -0500 [thread overview]
Message-ID: <20060417011642.GA2495@redhat.com> (raw)
In-Reply-To: <1145233627.9833.19.camel@localhost.localdomain>
On Mon, Apr 17, 2006 at 10:27:07AM +1000, Ben Herrenschmidt wrote:
> On Sun, 2006-04-16 at 17:42 -0500, Dave Jones wrote:
> > At least one laptop blew up on resume from suspend with a black screen
> > due to a lack of this patch. By only writing back config space that
> > is different, we minimise the possibility of accidents like this.
> >
> > Signed-off-by: Dave Jones <davej@redhat.com>
>
> I think it's a mistake to restore the command register before the rest.
> It should be restored last.
Adam Belay had a patch that did this, and a bunch of other similar
things (like making sure we never set BIST when restoring).
There are likely a number of similar possible improvements.
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2006-04-17 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-16 22:42 Improve PCI config space writeback Dave Jones
2006-04-17 0:27 ` Benjamin Herrenschmidt
2006-04-17 1:16 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060417011642.GA2495@redhat.com \
--to=davej@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.