From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Mishin Subject: Re: [RFC][PATCH] compat_uint64_t type Date: Mon, 17 Apr 2006 16:04:17 +0400 Message-ID: <200604171604.18471.dim@openvz.org> References: <444132C1.1020604@trash.net> <200604171459.13312.dim@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: dev@openvz.org, netfilter-devel@lists.netfilter.org, "David S. Miller" , kaber@trash.net Return-path: To: Andreas Schwab In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org On Monday 17 April 2006 15:51, Andreas Schwab wrote: > Dmitry Mishin writes: > > diff --git a/include/asm-ia64/compat.h b/include/asm-ia64/compat.h > > index 40d01d8..3e6417b 100644 > > --- a/include/asm-ia64/compat.h > > +++ b/include/asm-ia64/compat.h > > @@ -34,6 +34,8 @@ typedef s32 compat_long_t; > > typedef u32 compat_uint_t; > > typedef u32 compat_ulong_t; > > > > +typedef u64 __attribute__((aligned(4))) compat_uint64_t; > > The aligned attribute cannot decrease alignment. With my gcc (3.3.5) it can. Which solution do you propose? __attribute__((packed, aligned(4)))? Or #ifdef ARCH_HAS_FUNNY_ALIGNMENT struct compat_xt_counters { uint32_t cnt[4]; } #else #define compat_xt_counters xt_counters #endif ? > > Andreas. -- Thanks, Dmitry.