From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ryan Harper <ryanh@us.ibm.com>
Subject: Re: [PATCH] [vTPM] Script fixes for bash under FC5
Date: Mon, 17 Apr 2006 15:20:56 -0500
Message-ID: <20060417202056.GO16776@us.ibm.com>
References: <1145303685.23141.4.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <1145303685.23141.4.camel@localhost.localdomain>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefan Berger <stefanb@us.ibm.com>
Cc: xen-devel@lists.xensource.com, ewan@xensource.com
List-Id: xen-devel@lists.xenproject.org

* Stefan Berger <stefanb@us.ibm.com> [2006-04-17 14:56]:
> +	instance=$(cat $VTPMDB |                   \
>  	          awk -vvmname=$vmname             \

Any reason you use awk here

> +		instances=$(cat $VTPMDB |                \
>  		           gawk                          \

and gawk just about everywhere else?

> -	instances=`cat $VTPMDB |                 \
> +	instances=$(cat $VTPMDB |                \

> +	res=$(cat $VTPMDB |            \
>  	     gawk -vvmname=$vmname     \

> +	$(cat $VTPMDB |            \
>  	 gawk -vvmname=$vmname     \


# grep -n awk /etc/xen/scripts/vtpm-common.sh
64:               awk -vvmname=$vmname             \
90:                        gawk                          \
114:               gawk                          \
167:         gawk -vvmname=$vmname     \
200:     gawk -vvmname=$vmname     \


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@us.ibm.com