From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: Re: [linuxsh-dev] [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast Date: Tue, 18 Apr 2006 12:52:24 +0100 Message-ID: <20060418115224.GA8591@infradead.org> References: <1145232784.12804.2.camel@localhost.localdomain> <20060417012913.GA16821@linux-sh.org> <1145304037.9244.27.camel@localhost.localdomain> <1145310435.16138.83.camel@mindpipe> <20060417220512.GA16119@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Takashi Iwai Cc: Christoph Hellwig , Lee Revell , Adrian McMenamin , Paul Mundt , Alsa-devel , linux-sh , LKML List-Id: alsa-devel@alsa-project.org On Tue, Apr 18, 2006 at 12:17:46PM +0200, Takashi Iwai wrote: > Heh, the suggested line is what CondingStyle suggets -- the output of > indent program. Yeah, but better to fix "bad programming" :) indent only fixes indentation. Moving the if check to a different line as the function call changes more than indentation so indent doesn't do it. Yes, there's more to code codingstyle than just running indent :) ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932212AbWDRLwj (ORCPT ); Tue, 18 Apr 2006 07:52:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932217AbWDRLwj (ORCPT ); Tue, 18 Apr 2006 07:52:39 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:65439 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932212AbWDRLwi (ORCPT ); Tue, 18 Apr 2006 07:52:38 -0400 Date: Tue, 18 Apr 2006 12:52:24 +0100 From: Christoph Hellwig To: Takashi Iwai Cc: Christoph Hellwig , Lee Revell , Adrian McMenamin , Paul Mundt , Alsa-devel , linux-sh , LKML Subject: Re: [Alsa-devel] Re: [linuxsh-dev] [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast Message-ID: <20060418115224.GA8591@infradead.org> Mail-Followup-To: Christoph Hellwig , Takashi Iwai , Lee Revell , Adrian McMenamin , Paul Mundt , Alsa-devel , linux-sh , LKML References: <1145232784.12804.2.camel@localhost.localdomain> <20060417012913.GA16821@linux-sh.org> <1145304037.9244.27.camel@localhost.localdomain> <1145310435.16138.83.camel@mindpipe> <20060417220512.GA16119@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2006 at 12:17:46PM +0200, Takashi Iwai wrote: > Heh, the suggested line is what CondingStyle suggets -- the output of > indent program. Yeah, but better to fix "bad programming" :) indent only fixes indentation. Moving the if check to a different line as the function call changes more than indentation so indent doesn't do it. Yes, there's more to code codingstyle than just running indent :)