From: Jim Radford <radford@blackbean.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Paul Mackerras <paulus@samba.org>,
Git Mailing List <git@vger.kernel.org>
Subject: [RESEND] [PATCH] fix gitk with lots of tags
Date: Tue, 18 Apr 2006 11:06:14 -0700 [thread overview]
Message-ID: <20060418180614.GA31543@blackbean.org> (raw)
In-Reply-To: <20060406203637.GA15009@blackbean.org>
Hi Junio,
I've gotten no reposnse from Paul on this patch[1]. If it seems ok to
you, would you mind putting it in your queue for him? I hate to see
gitk die with "argument list too long" messages. They're so 640k.
Thanks,
-Jim
[1] Maybe he judges people by the color of their IP address?
Then again, he could just be busy.
---
This fix allow gitk to be used on repositories with lots of tags. It
bypasses git-rev-parse and passes its arguments to git-rev-list
directly to avoid tcl's argument list length restrictions.
Signed-Off-By: Jim Radford <radford@blackbean.org>
diff --git a/gitk b/gitk
index 26fa79a..40672fb 100755
--- a/gitk
+++ b/gitk
@@ -17,19 +17,11 @@ proc gitdir {} {
}
proc parse_args {rargs} {
- global parsed_args
-
- if {[catch {
- set parse_args [concat --default HEAD $rargs]
- set parsed_args [split [eval exec git-rev-parse $parse_args] "\n"]
- }]} {
- # if git-rev-parse failed for some reason...
- if {$rargs == {}} {
- set rargs HEAD
- }
- set parsed_args $rargs
+ if {$rargs == {}} {
+ return HEAD
+ } else {
+ return $rargs
}
- return $parsed_args
}
proc start_rev_list {rlargs} {
next prev parent reply other threads:[~2006-04-18 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 20:36 [PATCH] fix gitk with lots of tags Jim Radford
2006-04-18 18:06 ` Jim Radford [this message]
2006-04-18 18:38 ` [RESEND] " Linus Torvalds
2006-04-21 11:48 ` Paul Mackerras
2006-04-21 15:19 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060418180614.GA31543@blackbean.org \
--to=radford@blackbean.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.