From: Andi Kleen <ak@suse.de>
To: discuss@x86-64.org
Cc: Adrian Bunk <bunk@stusta.de>,
torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [discuss] Re: [PATCH] [6/6] i386: Move CONFIG_DOUBLEFAULT into arch/i386 where it belongs.
Date: Tue, 18 Apr 2006 22:12:13 +0200 [thread overview]
Message-ID: <200604182212.13835.ak@suse.de> (raw)
In-Reply-To: <20060418190528.GL11582@stusta.de>
On Tuesday 18 April 2006 21:05, Adrian Bunk wrote:
> On Tue, Apr 18, 2006 at 12:35:22PM +0200, Andi Kleen wrote:
> >
> > Signed-off-by: Andi Kleen <ak@suse.de>
> >...
>
> NAK.
>
> When submitting a patch that is the revert of a patch that went
> into Linus' tree just 8 days ago [1], I'd expect at least:
> - a Cc to the people involved with the patch you are reverting
> - a note that you are reverting a recent patch in your patch
> description
> - an explanation why you disagree with the patch you are reverting
The subject was very clear. i386 options belong into arch/i386.
> If you disagree with a patch, please speak up when it's submitted or
> discuss it after you've seen it in the tree. But don't play such silly
> revert-and-hope-they-don't-notice-I've-reverted-it games.
I moved it because I noticed that my x86-64 configuration files
had this strange new symbol. I also did a grep and no other architecture
other than i386 uses it.
i386 specific hacks belong into arch/i386
-Andi (who actually thinks the whole thing was always a bad idea - saving
a few K but giving up such debugging is a poor trade off)
next prev parent reply other threads:[~2006-04-18 20:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 10:35 [PATCH] [6/6] i386: Move CONFIG_DOUBLEFAULT into arch/i386 where it belongs Andi Kleen
2006-04-18 19:05 ` Adrian Bunk
2006-04-18 20:12 ` Andi Kleen [this message]
2006-04-19 2:08 ` [discuss] " Randy.Dunlap
2006-04-20 11:49 ` Adrian Bunk
2006-04-20 13:26 ` Andi Kleen
2006-04-20 13:47 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604182212.13835.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.