From: Pavel Machek <pavel@ucw.cz>
To: "Yu, Luming" <luming.yu@intel.com>
Cc: dtor_core@ameritech.net,
Alexey Starikovskiy <alexey_y_starikovskiy@linux.intel.com>,
Xavier Bestel <xavier.bestel@free.fr>,
Matthew Garrett <mjg59@srcf.ucam.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH] Make ACPI button driver an input device
Date: Thu, 20 Apr 2006 21:55:50 +0000 [thread overview]
Message-ID: <20060420215549.GA2352@ucw.cz> (raw)
In-Reply-To: <554C5F4C5BA7384EB2B412FD46A3BAD13787F2@pdsmsx411.ccr.corp.intel.com>
Hi!
> >> > There are keyboards with power/sleep buttons. It makes
> >sense they have
> >> > the same behavior than ACPI buttons.
> >> Agree, make them behave like ACPI buttons -- remove them
> >from input stream, as they do not belong there...
> >
> >What if there is no ACPI? What if I want to remap the button to do
> >something else? Input layer is the proper place for them.
>
> If you define input layer as a universe place to all manual input
> activity, then I agree to port some type of ACPI event into
> input layer. But it shouldn't be a fake keyboard scancode,
> My suggestion is to have a separate input event type,e.g. EV_ACPI
> for acpi event layer.
There's nothing fake about it. Power button is just that - a button.
Having EV_ACPI might make sense for thermal/battery events, but not
for normal keys.
--
Thanks, Sharp!
next prev parent reply other threads:[~2006-04-22 19:16 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 7:27 [RFC] [PATCH] Make ACPI button driver an input device Yu, Luming
2006-04-21 7:27 ` Yu, Luming
2006-04-20 21:55 ` Pavel Machek [this message]
2006-04-24 14:51 ` Dmitry Torokhov
2006-04-21 11:37 ` Martin Mares
2006-04-21 12:21 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2006-04-25 14:17 Yu, Luming
2006-04-25 14:17 ` Yu, Luming
2006-04-20 5:45 Yu, Luming
2006-04-20 5:45 ` Yu, Luming
2006-04-20 7:37 ` Matthew Garrett
2006-04-20 15:35 ` Alexey Starikovskiy
2006-04-20 15:38 ` Matthew Garrett
2006-04-20 15:57 ` Alexey Starikovskiy
2006-04-20 16:11 ` Xavier Bestel
2006-04-20 16:33 ` Alexey Starikovskiy
2006-04-20 16:44 ` Matthew Garrett
2006-04-20 16:47 ` Alexey Starikovskiy
2006-04-20 16:55 ` Matthew Garrett
2006-04-20 17:06 ` Alexey Starikovskiy
2006-04-20 22:03 ` Pavel Machek
2006-04-20 19:30 ` Dmitry Torokhov
2006-04-20 20:07 ` Xavier Bestel
2006-04-20 20:07 ` Xavier Bestel
2006-04-21 8:52 ` Alexey Starikovskiy
2006-04-21 8:52 ` Alexey Starikovskiy
2006-04-20 22:04 ` Pavel Machek
2006-04-21 12:56 ` Dmitry Torokhov
2006-04-21 12:56 ` Dmitry Torokhov
2006-04-20 22:01 ` Pavel Machek
2006-04-22 20:59 ` David Weinehall
2006-04-20 16:15 ` Matthew Garrett
2006-04-20 16:28 ` Alexey Starikovskiy
2006-04-20 16:32 ` Matthew Garrett
2006-04-20 16:35 ` Alexey Starikovskiy
2006-04-20 16:45 ` Matthew Garrett
2006-04-20 22:10 ` Pavel Machek
2006-04-20 16:58 ` Martin Mares
2006-04-20 17:08 ` Alexey Starikovskiy
2006-04-20 22:07 ` Pavel Machek
2006-04-24 6:54 ` Alexey Starikovskiy
2006-04-24 8:31 ` Pavel Machek
2006-04-24 14:39 ` Alexey Starikovskiy
2006-04-24 15:09 ` Matthew Garrett
2006-04-28 17:43 ` Stefan Seyfried
2006-04-28 17:43 ` Stefan Seyfried
2006-04-19 19:53 Matthew Garrett
2006-04-19 20:04 ` Dominik Brodowski
2006-04-19 20:24 ` Matthew Garrett
2006-04-24 14:45 ` Dmitry Torokhov
2006-04-24 15:10 ` Matthew Garrett
2006-04-24 16:05 ` Richard Purdie
2006-04-24 16:26 ` Dmitry Torokhov
2006-04-24 17:05 ` Richard Purdie
2006-04-24 20:34 ` Pavel Machek
2006-04-24 20:59 ` Richard Purdie
2006-04-24 21:29 ` Pavel Machek
2006-04-24 20:20 ` Pavel Machek
2006-04-20 21:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060420215549.GA2352@ucw.cz \
--to=pavel@ucw.cz \
--cc=alexey_y_starikovskiy@linux.intel.com \
--cc=dtor_core@ameritech.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=xavier.bestel@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.