All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] kernel/kthread.c: make kthread_stop_sem() static
Date: Sun, 23 Apr 2006 13:40:23 +0200	[thread overview]
Message-ID: <20060423114022.GJ5010@stusta.de> (raw)

This patch makes the needlessly global kthread_stop_sem() static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 include/linux/kthread.h |   12 ------------
 kernel/kthread.c        |   26 +++++++++++++++++---------
 2 files changed, 17 insertions(+), 21 deletions(-)

--- linux-2.6.17-rc1-mm3-full/include/linux/kthread.h.old	2006-04-23 01:32:40.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/include/linux/kthread.h	2006-04-23 01:33:20.000000000 +0200
@@ -70,18 +70,6 @@
 int kthread_stop(struct task_struct *k);
 
 /**
- * kthread_stop_sem: stop a thread created by kthread_create().
- * @k: thread created by kthread_create().
- * @s: semaphore that @k waits on while idle.
- *
- * Does essentially the same thing as kthread_stop() above, but wakes
- * @k by calling up(@s).
- *
- * Returns the result of threadfn(), or -EINTR if wake_up_process()
- * was never called. */
-int kthread_stop_sem(struct task_struct *k, struct semaphore *s);
-
-/**
  * kthread_should_stop: should this kthread return now?
  *
  * When someone calls kthread_stop on your kthread, it will be woken
--- linux-2.6.17-rc1-mm3-full/kernel/kthread.c.old	2006-04-23 01:30:48.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/kernel/kthread.c	2006-04-23 01:33:11.000000000 +0200
@@ -164,15 +164,18 @@
 	set_task_cpu(k, cpu);
 	k->cpus_allowed = cpumask_of_cpu(cpu);
 }
-EXPORT_SYMBOL(kthread_bind);
 
-int kthread_stop(struct task_struct *k)
-{
-	return kthread_stop_sem(k, NULL);
-}
-EXPORT_SYMBOL(kthread_stop);
-
-int kthread_stop_sem(struct task_struct *k, struct semaphore *s)
+/**
+ * kthread_stop_sem: stop a thread created by kthread_create().
+ * @k: thread created by kthread_create().
+ * @s: semaphore that @k waits on while idle.
+ *
+ * Does essentially the same thing as kthread_stop() above, but wakes
+ * @k by calling up(@s).
+ *
+ * Returns the result of threadfn(), or -EINTR if wake_up_process()
+ * was never called. */
+static int kthread_stop_sem(struct task_struct *k, struct semaphore *s)
 {
 	int ret;
 
@@ -201,7 +204,12 @@
 
 	return ret;
 }
-EXPORT_SYMBOL(kthread_stop_sem);
+
+int kthread_stop(struct task_struct *k)
+{
+	return kthread_stop_sem(k, NULL);
+}
+EXPORT_SYMBOL(kthread_stop);
 
 static __init int helper_init(void)
 {


             reply	other threads:[~2006-04-23 11:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-23 11:40 Adrian Bunk [this message]
2006-04-23 13:37 ` [RFC: 2.6 patch] kernel/kthread.c: make kthread_stop_sem() static Ingo Oeser
2006-04-26 12:31   ` [RFC: 2.6 patch] kernel/kthread.c: possible cleanups Adrian Bunk
2006-04-26 17:39     ` Ingo Oeser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060423114022.GJ5010@stusta.de \
    --to=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.