From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Cleanup of portdrv_pci.c
Date: Mon, 24 Apr 2006 16:54:31 +0000 [thread overview]
Message-ID: <20060424165431.GA17018@kroah.com> (raw)
In-Reply-To: <444CFCAD.8020002@nachtwindheim.de>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On Mon, Apr 24, 2006 at 06:28:29PM +0200, Henne wrote:
> From: Henrik Kretzschmar <henne@nachtwindheim.de>
>
> Marking the pci_device_id table of portdrv_pci.c as __devinitdata and
> making save/resore_config() dependend tp CONFIG_PM
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
> ---
>
> --- linux-2.6.17-rc2/drivers/pci/pcie/portdrv_pci.c 2006-04-24
> 13:31:00.000000000 +0200
> +++ linux_test/drivers/pci/pcie/portdrv_pci.c 2006-04-24
> 18:20:29.000000000 +0200
> @@ -30,6 +30,7 @@
> /* global data */
> static const char device_name[] = "pcieport-driver";
>
> +#ifdef CONFIG_PM
No, please no ifdefs in .c files if you can help it.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2006-04-24 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 16:28 [KJ] [PATCH] Cleanup of portdrv_pci.c Henne
2006-04-24 16:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060424165431.GA17018@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.