From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org, heiko.carstens@de.ibm.com
Subject: Re: [patch 11/13] s390: instruction processing damage handling.
Date: Tue, 25 Apr 2006 22:14:38 +0200 [thread overview]
Message-ID: <200604252214.38662.arnd@arndb.de> (raw)
In-Reply-To: <20060424165823.0065c826.akpm@osdl.org>
Am Tuesday 25 April 2006 01:58 schrieb Andrew Morton:
> Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> > + tmp = get_clock();
>
> s390 has a get_clock()? I guess you don't use i2c much.
>
> We shouldn't use such generic-looking identifiers for arch-specific things.
> But I guess you can defer the great renaming to s390_get_clock() until
> something actually breaks.
Many places could probably just use get_cycles() if they don't need
sub-cycle resolution. Also such an update could be combined with
a move to the new store-clock-fast instruction.
Arnd <><
next prev parent reply other threads:[~2006-04-25 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 15:05 [patch 11/13] s390: instruction processing damage handling Martin Schwidefsky
2006-04-24 23:58 ` Andrew Morton
2006-04-25 20:14 ` Arnd Bergmann [this message]
2006-04-28 7:33 ` Josef Sipek
2006-04-28 8:39 ` Heiko Carstens
2006-04-28 9:24 ` Martin Schwidefsky
2006-04-28 13:43 ` Paulo Marques
2006-04-28 14:53 ` Martin Schwidefsky
2006-04-28 16:46 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604252214.38662.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.