From: Greg KH <greg@kroah.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] class_device_add needs error checks
Date: Tue, 25 Apr 2006 15:39:58 -0700 [thread overview]
Message-ID: <20060425223958.GA30677@kroah.com> (raw)
In-Reply-To: <20060421134027.3198974e@localhost.localdomain>
On Fri, Apr 21, 2006 at 01:40:27PM -0700, Stephen Hemminger wrote:
> + if (atomic_read(&class_dev->kobj.kref.refcount))
> + kobject_del(&class_dev->kobj);
Yeah, we can't do this, we should not be mucking around in the kref core
like this.
Are you having problems where class_device_add() should be failing and
it isn't?
Other than the above, the patch almost looked good :)
thanks,
greg k-h
next prev parent reply other threads:[~2006-04-25 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 20:40 [RFC] class_device_add needs error checks Stephen Hemminger
2006-04-25 22:39 ` Greg KH [this message]
2006-04-26 16:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060425223958.GA30677@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.