From: apgo@patchbomb.org (Arthur Othieno)
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] constify drivers/block/floppy.c (2.6.17-rc1-mm3)
Date: Wed, 26 Apr 2006 03:19:49 +0000 [thread overview]
Message-ID: <20060426031949.GA1363@krypton> (raw)
In-Reply-To: <20060425180313.GA7096@rhlx01.fht-esslingen.de>
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
On Tue, Apr 25, 2006 at 08:03:13PM +0200, Andreas Mohr wrote:
> Hello all,
>
> constify the few floppy module variables that can be constified
> (see objdump -x floppy.ko).
>
> Patch against 2.6.17-rc1-mm3.
>
> Signed-off-by: Andreas Mohr <andi@lisas.de>
>
> Thanks!
>
>
> --- linux-2.6.17-rc1-mm3/drivers/block/floppy.c 2006-04-03 05:22:10.000000000 +0200
> +++ linux-2.6.17-rc1-mm3/drivers/block/floppy.c.const 2006-04-25 19:57:40.000000000 +0200
> @@ -3954,7 +3954,7 @@
> .media_changed = check_floppy_change,
> .revalidate_disk = floppy_revalidate,
> };
> -static char *table[] = {
> +static const char * const table[] = {
warning: initialization makes pointer from integer without a cast
> "", "d360", "h1200", "u360", "u720", "h360", "h720",
> "u1440", "u2880", "CompaQ", "h1440", "u1680", "h410",
> "u820", "h1476", "u1722", "h420", "u830", "h1494", "u1743",
> @@ -3962,11 +3962,11 @@
> "u3200", "u3520", "u3840", "u1840", "u800", "u1600",
> NULL
> };
> -static int t360[] = { 1, 0 },
> +static const int t360[] = { 1, 0 },
> t1200[] = { 2, 5, 6, 10, 12, 14, 16, 18, 20, 23, 0 },
> t3in[] = { 8, 9, 26, 27, 28, 7, 11, 15, 19, 24, 25, 29, 31, 3, 4, 13,
> 17, 21, 22, 30, 0 };
> -static int *table_sup[] =
> +static const int * const table_sup[] =
warning: initialization makes pointer from integer without a cast
> { NULL, t360, t1200, t3in + 5 + 8, t3in + 5, t3in, t3in };
>
> static void __init register_devfs_entries(int drive)
>
Please at least compile test your patches. Thanks.
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-04-26 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 18:03 [KJ] [PATCH] constify drivers/block/floppy.c (2.6.17-rc1-mm3) Andreas Mohr
2006-04-26 3:19 ` Arthur Othieno [this message]
2006-04-26 7:20 ` Andreas Mohr
2006-04-26 14:56 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060426031949.GA1363@krypton \
--to=apgo@patchbomb.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.