All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jens Axboe <axboe@suse.de>
Cc: Al Viro <viro@ftp.linux.org.uk>,
	Akinobu Mita <mita@miraclelinux.com>,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 3/3] use kref for bio
Date: Tue, 25 Apr 2006 22:18:13 -0700	[thread overview]
Message-ID: <20060426051813.GB332@kroah.com> (raw)
In-Reply-To: <20060426051344.GT4102@suse.de>

On Wed, Apr 26, 2006 at 07:13:44AM +0200, Jens Axboe wrote:
> On Wed, Apr 26 2006, Al Viro wrote:
> > On Wed, Apr 26, 2006 at 10:11:02AM +0800, Akinobu Mita wrote:
> > > Use kref for reference counter of bio.
> > > This patch also removes BUG_ON() for freeing unreferenced bio.
> > > But kref can detect it if CONFIG_DEBUG_SLAB is enabled.
> >  
> > *Ugh*
> > 
> > Let's _not_.  It's extra overhead for no good reason.
> 
> Completely agree. That goes for the other block layer kref patches as
> well.

I also agree, there's a reason I never tried to convert them in the past
:)

thanks,

greg k-h

  reply	other threads:[~2006-04-26  5:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-26  2:10 [patch 0/3] use kref Akinobu Mita
2006-04-26  2:11 ` [patch 1/3] use kref for blk_queue_tag Akinobu Mita
2006-04-26  2:42   ` Nick Piggin
2006-04-26  5:17   ` Greg KH
2006-04-26  2:11 ` [patch 2/3] use kref for io_context Akinobu Mita
2006-04-26  2:11 ` [patch 3/3] use kref for bio Akinobu Mita
2006-04-26  2:26   ` Al Viro
2006-04-26  5:13     ` Jens Axboe
2006-04-26  5:18       ` Greg KH [this message]
2006-04-26  7:20         ` Akinobu Mita
2006-04-26  7:39           ` Al Viro
2006-04-26  9:29             ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060426051813.GB332@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mita@miraclelinux.com \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.