From: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
To: Andrew Morton <akpm@osdl.org>
Cc: NeilBrown <neilb@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove softlockup from invalidate_mapping_pages.
Date: Wed, 26 Apr 2006 22:48:09 +0200 [thread overview]
Message-ID: <20060426204809.GA15462@uio.no> (raw)
In-Reply-To: <20060420003839.1a41c36f.akpm@osdl.org>
On Thu, Apr 20, 2006 at 12:38:39AM -0700, Andrew Morton wrote:
> In practice, I think it's OK - there's no _reason_ why anyone would want to
> trash the ->index of a just-truncated page. However I think it'd be saner
> to a) only look at ->index after we've tried to lock the page and b) make
> sure that ->index is really "to the right" of where we're currently at.
>
> How's this look?
>
> --- devel/mm/truncate.c~remove-softlockup-from-invalidate_mapping_pages 2006-04-20 00:20:49.000000000 -0700
> +++ devel-akpm/mm/truncate.c 2006-04-20 00:28:18.000000000 -0700
I tried this patch against 2.6.17-rc2 (I hoped that it might be fixing my
kswapd oopses too, as they seem related; see
http://lkml.org/lkml/2006/4/26/124 and followups), and it simply makes my
machine hang on bootup -- it seems to make modprobe hang forever on some lock
or something right after it loads raid6.ko (pulled in by evms_activate) in
initramfs. Without the patch, the machine boots just fine.
Since it's on serial console, I've got a SysRq+T log if it helps you.
/* Steinar */
--
Homepage: http://www.sesse.net/
next prev parent reply other threads:[~2006-04-26 20:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060420160549.7637.patches@notabene>
2006-04-20 6:29 ` [PATCH] Remove softlockup from invalidate_mapping_pages NeilBrown
2006-04-20 7:38 ` Andrew Morton
2006-04-20 9:24 ` Neil Brown
2006-04-20 9:30 ` Jens Axboe
2006-04-20 9:50 ` Neil Brown
2006-04-20 9:59 ` Jens Axboe
2006-04-20 10:26 ` Neil Brown
2006-04-20 9:52 ` Andrew Morton
2006-04-20 10:52 ` Jens Axboe
2006-04-26 20:48 ` Steinar H. Gunderson [this message]
2006-04-26 20:58 ` Andrew Morton
2006-04-26 21:26 ` Steinar H. Gunderson
2006-05-01 16:07 ` Steinar H. Gunderson
2006-05-13 13:49 ` [PATCH] Remove softlockup from invalidate_mapping_pages. (might be dm related) Steinar H. Gunderson
2006-05-13 14:33 ` Andrew Morton
2006-05-13 14:43 ` Steinar H. Gunderson
2006-05-13 14:51 ` Andrew Morton
2006-05-13 15:00 ` Steinar H. Gunderson
2006-05-13 15:24 ` Andrew Morton
2006-05-13 15:24 ` Andrew Morton
2006-05-13 15:32 ` Steinar H. Gunderson
2006-05-13 15:43 ` Andrew Morton
2006-05-13 15:43 ` Andrew Morton
2006-05-13 17:14 ` Steinar H. Gunderson
2006-05-13 23:28 ` Steinar H. Gunderson
2006-05-13 22:37 ` Alasdair G Kergon
2006-05-13 22:37 ` [dm-devel] " Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060426204809.GA15462@uio.no \
--to=sgunderson@bigfoot.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.