From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714AbWD1ATw (ORCPT ); Thu, 27 Apr 2006 20:19:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751818AbWD1ATw (ORCPT ); Thu, 27 Apr 2006 20:19:52 -0400 Received: from mx1.suse.de ([195.135.220.2]:24537 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1751823AbWD1ATs (ORCPT ); Thu, 27 Apr 2006 20:19:48 -0400 Date: Thu, 27 Apr 2006 17:18:16 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org, dsd@gentoo.org, mm-commits@vger.kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, Greg Kroah-Hartman Subject: [patch 07/24] tipar oops fix Message-ID: <20060428001816.GH18750@kroah.com> References: <20060428001226.204293000@quad.kroah.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="tipar-oops-fix.patch" In-Reply-To: <20060428001557.GA18750@kroah.com> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org -stable review patch. If anyone has any objections, please let us know. ------------------ From: Daniel Drake If compiled into the kernel, parport_register_driver() is called before the parport driver has been initalised. This means that it is expected that tp_count is 0 after the parport_register_driver() call() - tipar's attach function will not be called until later during bootup. Signed-off-by: Daniel Drake Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- drivers/char/tipar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.16.11.orig/drivers/char/tipar.c +++ linux-2.6.16.11/drivers/char/tipar.c @@ -515,7 +515,7 @@ tipar_init_module(void) err = PTR_ERR(tipar_class); goto out_chrdev; } - if (parport_register_driver(&tipar_driver) || tp_count == 0) { + if (parport_register_driver(&tipar_driver)) { printk(KERN_ERR "tipar: unable to register with parport\n"); err = -EIO; goto out_class; --